From: Paolo Abeni <pabeni@redhat.com>
To: Leo Li <leoyang.li@nxp.com>, Andrew Lunn <andrew@lunn.ch>,
Luo Jie <quic_luoj@quicinc.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
David Bauer <mail@david-bauer.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Viorel Suman <viorel.suman@nxp.com>, Wei Fang <wei.fang@nxp.com>
Subject: Re: [PATCH v3 1/2] net: phy: at803x: fix the wol setting functions
Date: Tue, 01 Aug 2023 11:16:24 +0200 [thread overview]
Message-ID: <9912df2897bed863ad541807354d49db95970668.camel@redhat.com> (raw)
In-Reply-To: <AM0PR04MB6289323F6F93E197103A225D8F05A@AM0PR04MB6289.eurprd04.prod.outlook.com>
On Mon, 2023-07-31 at 14:58 +0000, Leo Li wrote:
> > -----Original Message-----
> > From: Andrew Lunn <andrew@lunn.ch>
> > Sent: Saturday, July 29, 2023 3:14 AM
> > To: Leo Li <leoyang.li@nxp.com>
> > Cc: Heiner Kallweit <hkallweit1@gmail.com>; Russell King
> > <linux@armlinux.org.uk>; David S . Miller <davem@davemloft.net>; Jakub
> > Kicinski <kuba@kernel.org>; David Bauer <mail@david-bauer.net>;
> > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Viorel Suman
> > <viorel.suman@nxp.com>; Wei Fang <wei.fang@nxp.com>
> > Subject: Re: [PATCH v3 1/2] net: phy: at803x: fix the wol setting functions
> >
> > On Fri, Jul 28, 2023 at 04:53:19PM -0500, Li Yang wrote:
> > > In commit 7beecaf7d507 ("net: phy: at803x: improve the WOL feature"),
> > > it seems not correct to use a wol_en bit in a 1588 Control Register
> > > which is only available on AR8031/AR8033(share the same phy_id) to
> > > determine if WoL is enabled. Change it back to use
> > > AT803X_INTR_ENABLE_WOL for determining the WoL status which is
> > > applicable on all chips supporting wol. Also update the
> > > at803x_set_wol() function to only update the 1588 register on chips having
> > it.
> >
> > Do chips which do not have the 1588 register not have WoL? Or WoL
> > hardware is always enabled, but you still need to enable the interrupt.
>
> Some of them do and some don't, which is removed in the other patch
> from the series. Since I don't find the register to enable it, I
> guess it always enabled.
>
> >
> > Have you tested on a range of PHY? It might be better to split this patch up a
> > bit. If it causes regressions, having smaller patches can make it easier to find
> > which change broken it.
>
> No, I only have AR8035 to test with. Changes for other chips are
> according to the datasheet. It would be good if others having the
> hardware can test it too.
Adding Luo Jie for awareness.
@Luo Jie: do you have access to other chips handled by this driver
other then AR8035? could you please test this series:
https://patchwork.kernel.org/project/netdevbpf/list/?series=770734
?
Thanks!
Paolo
next prev parent reply other threads:[~2023-08-01 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 21:53 [PATCH v3 0/2] fix at803x wol setting Li Yang
2023-07-28 21:53 ` [PATCH v3 1/2] net: phy: at803x: fix the wol setting functions Li Yang
2023-07-29 8:14 ` Andrew Lunn
2023-07-31 14:58 ` Leo Li
2023-08-01 9:16 ` Paolo Abeni [this message]
2023-08-02 9:50 ` Jie Luo
2023-08-02 10:22 ` Russell King (Oracle)
2023-08-02 18:43 ` Leo Li
2023-07-28 21:53 ` [PATCH v3 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032 Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9912df2897bed863ad541807354d49db95970668.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mail@david-bauer.net \
--cc=netdev@vger.kernel.org \
--cc=quic_luoj@quicinc.com \
--cc=viorel.suman@nxp.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®