Re: Regressions can bus with MCP2515 on sama5d3 connected over SPI stop working on kernel > 5.4.271

Re: Regressions can bus with MCP2515 on sama5d3 connected over SPI stop working on kernel > 5.4.271

[Linux regression tracking (Thorsten Leemhuis)]

Hi! Mark and Manivannan, do you by chance have an idea what might be
wrong with Daniel's system or can point us in the direction of people
that might be able to help? See
https://lore.kernel.org/all/2ede8f49-41f8-4d9a-83e4-ea5d4d1677fe@mydatex.cz/
for the initial report (but it is in the quote below, too).

On 13.03.24 00:22, Daniel Smolik wrote:
> I am not very familiar with bisecting :-(  I have found how to solve
> another problem and compile 5.5.0 kernel. And now I know that latest
> working is 5.4.271 and first not working is 5.5.0.

Let's wait first if Mark and Manivannan might haven an idea. And in case
you in the end have to bisect: please follow the guide I pointed to and
tell me where you have the problem, as the guide (and an earlier mail,
too!) tells you that you need to bisect from 5.4 to 5.5.

Ciao, Thorsten

> Dne 12. 03. 24 v 20:57 Daniel Smolik napsal(a):
>> Hi ,
>> 6.8  is affected   with this bug.  I try bisect the bug.
>>
>> Regards
>>             Dan
>>
>> Dne 12. 03. 24 v 11:39 Linux regression tracking (Thorsten Leemhuis)
>> napsal(a):
>>> On 12.03.24 11:27, Dan Smolik wrote:
>>>> Dne 12. 03. 24 v 11:19 Linux regression tracking (Thorsten Leemhuis)
>>>> napsal(a):
>>>>> On 11.03.24 22:55, Daniel Smolik wrote:
>>>>>> I have found problem with kernel > 5.4.271 (long term) on sama5d3.
>>>>>> When
>>>>>> I config can bus with:
>>>>>>
>>>>>> ip link set can0 type can bitrate 125000 triple-sampling on
>>>>>>
>>>>>> and type
>>>>>> ifconfig can0 up
>>>>>>
>>>>>> prompt never returns and cannot run eg. ip a (never returns) existing
>>>>>> ssh connection works but can´t do new one.
>>>>>>
>>>>>>
>>>>>>     I have my own daughter  board with can bus driver MCP2515
>>>>>> connected
>>>>>> over SPI bus. There is
>>>>>> snippet of my DTB:
>>>>>>
>>>>>>    can0: can@0 {
>>>>>>                                           compatible =
>>>>>> "microchip,mcp2515";
>>>>>>                                           reg = <0>;
>>>>>>                                           clocks = <&can0_osc_fixed>;
>>>>>>                                           interrupt-parent = <&pioD>;
>>>>>>                                           interrupts = <29
>>>>>> IRQ_TYPE_EDGE_RISING>;
>>>>>> spi-max-frequency = <10000000>;
>>>>>>                                       };
>>>>>>
>>>>>> with this all working  perfect  on long term kernels 4.19.  I try
>>>>>> switch
>>>>>> to newer kernel and latest I get working is 5.4.271. Kernel 5.5.0
>>>>>> -5.5.6 I can´t  compile and 5.5.14  is affected with bug.
>>>>> The two important question here are:
>>>>>
>>>>> * Is mainline (e.g. 6.8) affected as well? That determines if the
>>>>> regular developers or the stable team has to look into this.
>>>> I mean yes,  I tested 6.6.21 and is affected.   6.8 I can test today
>>>> afternoon.
>>> Yes, please test 6.8.
>>>
>>>>> * Could you bisect the problem (e.g. I assume between 5.4.271 and
>>>>> 5.4.272)? I'm working on a guide that explains this:
>>>>> https://www.leemhuis.info/files/misc/How%20to%20bisect%20a%20Linux%20kernel%20regression%20%e2%80%94%20The%20Linux%20Kernel%20documentation.html
>>>> Yes I try this but it looks like that latest good is 5.4.271 and first
>>>> bad us 5.5.0  but this kernel fail when building to arm platform. 
>>>> First
>>>> which I build for arm is 5.5.14.
>>>>
>>>> I try bisecting but when I can't build kernel what can I do ?
>>> Bisect between 5.4 and 5.5 and during the bisection use "git cherry-pick
>>> --no-commit <sha1sum>" to apply the fix(es) without committing them
>>> before you build; once the build is ready, use "git reset --hard" to
>>> reset things.
>>>
>>> But please check 6.8 first; if it is affected we can CC a few
>>> developers. If you are lucky they have an idea what might be wrong here
>>> and then no bisection might be needed.
>>>
>>> Ciao, Thorsten
>>
>>
> 
> 
> 

Re: Regressions can bus with MCP2515 on sama5d3 connected over SPI stop working on kernel > 5.4.271

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 819 bytes --]

On 13.03.2024 10:16:47, Linux regression tracking (Thorsten Leemhuis) wrote:
> Hi! Mark and Manivannan, do you by chance have an idea what might be
> wrong with Daniel's system or can point us in the direction of people
> that might be able to help? See
> https://lore.kernel.org/all/2ede8f49-41f8-4d9a-83e4-ea5d4d1677fe@mydatex.cz/
> for the initial report (but it is in the quote below, too).

At the first glance the mcp251x.c changes between v5.4 and v5.5 look
unrelated.

I try to find some time to setup bisecting on an imx6.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Regressions can bus with MCP2515 on sama5d3 connected over SPI stop working on kernel > 5.4.271

[Daniel Smolik]

Hi all,

this is my first bisection please be lenient :-) Threse is a result:


marvin@marvin:/usr/src/linux$ git bisect good
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[52f96cd135b160d44db4cb62a5b614b3bca20fbc] net: stmmac: xgmac: Remove 
uneeded computation for RFA/RFD

Regards
             Dan



Dne 13. 03. 24 v 11:35 Marc Kleine-Budde napsal(a):

> On 13.03.2024 10:16:47, Linux regression tracking (Thorsten Leemhuis) wrote:
>> Hi! Mark and Manivannan, do you by chance have an idea what might be
>> wrong with Daniel's system or can point us in the direction of people
>> that might be able to help? See
>> https://lore.kernel.org/all/2ede8f49-41f8-4d9a-83e4-ea5d4d1677fe@mydatex.cz/
>> for the initial report (but it is in the quote below, too).
> At the first glance the mcp251x.c changes between v5.4 and v5.5 look
> unrelated.
>
> I try to find some time to setup bisecting on an imx6.
>
> Marc
>

Re: Regressions can bus with MCP2515 on sama5d3 connected over SPI stop working on kernel > 5.4.271

[Linux regression tracking (Thorsten Leemhuis)]

On 13.03.24 12:22, Daniel Smolik wrote:
> 
> this is my first bisection please be lenient :-) Threse is a result:
> 
> marvin@marvin:/usr/src/linux$ git bisect good
> Bisecting: 0 revisions left to test after this (roughly 0 steps)
> [52f96cd135b160d44db4cb62a5b614b3bca20fbc] net: stmmac: xgmac: Remove
> uneeded computation for RFA/RFD

Have you tried reverting that commit on-top of 5.5 and/or 6.8 to see if
this fixes the problem, as advised by the bisection guide I mentioned?

Ciao, Thorsten

> Dne 13. 03. 24 v 11:35 Marc Kleine-Budde napsal(a):
> 
>> On 13.03.2024 10:16:47, Linux regression tracking (Thorsten Leemhuis)
>> wrote:
>>> Hi! Mark and Manivannan, do you by chance have an idea what might be
>>> wrong with Daniel's system or can point us in the direction of people
>>> that might be able to help? See
>>> https://lore.kernel.org/all/2ede8f49-41f8-4d9a-83e4-ea5d4d1677fe@mydatex.cz/
>>> for the initial report (but it is in the quote below, too).
>> At the first glance the mcp251x.c changes between v5.4 and v5.5 look
>> unrelated.
>>
>> I try to find some time to setup bisecting on an imx6.
>>
>> Marc
>>
> 
> 
> 

Re: Regressions can bus with MCP2515 on sama5d3 connected over SPI stop working on kernel > 5.4.271

[Daniel Smolik]

No, if you kick me little I do it:-)

git clone -o mainline --no-checkout \
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git ~/linux/
cd ~/linux/
git remote add -t master stable \
   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
git checkout --detach v6.8

cd ~/linux/

git cherry-pick
--no-commit   52f96cd135b160d44db4cb62a5b614b3bca20fbc]

Is this right way ?

	Regards
			Dan






Dne 13. 03. 24 v 12:32 Linux regression tracking (Thorsten Leemhuis) 
napsal(a):
> On 13.03.24 12:22, Daniel Smolik wrote:
>> this is my first bisection please be lenient :-) Threse is a result:
>>
>> marvin@marvin:/usr/src/linux$ git bisect good
>> Bisecting: 0 revisions left to test after this (roughly 0 steps)
>> [52f96cd135b160d44db4cb62a5b614b3bca20fbc] net: stmmac: xgmac: Remove
>> uneeded computation for RFA/RFD
> Have you tried reverting that commit on-top of 5.5 and/or 6.8 to see if
> this fixes the problem, as advised by the bisection guide I mentioned?
>
> Ciao, Thorsten
>
>> Dne 13. 03. 24 v 11:35 Marc Kleine-Budde napsal(a):
>>
>>> On 13.03.2024 10:16:47, Linux regression tracking (Thorsten Leemhuis)
>>> wrote:
>>>> Hi! Mark and Manivannan, do you by chance have an idea what might be
>>>> wrong with Daniel's system or can point us in the direction of people
>>>> that might be able to help? See
>>>> https://lore.kernel.org/all/2ede8f49-41f8-4d9a-83e4-ea5d4d1677fe@mydatex.cz/
>>>> for the initial report (but it is in the quote below, too).
>>> At the first glance the mcp251x.c changes between v5.4 and v5.5 look
>>> unrelated.
>>>
>>> I try to find some time to setup bisecting on an imx6.
>>>
>>> Marc
>>>
>>
>>

Re: Regressions can bus with MCP2515 on sama5d3 connected over SPI stop working on kernel > 5.4.271

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

On 13.03.2024 12:22:25, Daniel Smolik wrote:
> this is my first bisection please be lenient :-) Threse is a result:
> 
> marvin@marvin:/usr/src/linux$ git bisect good
> Bisecting: 0 revisions left to test after this (roughly 0 steps)
> [52f96cd135b160d44db4cb62a5b614b3bca20fbc] net: stmmac: xgmac: Remove
> uneeded computation for RFA/RFD

I think you still miss a bisection step.

The commit 52f96cd135b1 ("net: stmmac: xgmac: Remove uneeded computation
for RFA/RFD") is unrelated to CAN problem you described. It's in the
stmmac Ethernet driver.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Regressions can bus with MCP2515 on sama5d3 connected over SPI stop working on kernel > 5.4.271

[Daniel Smolik]

Hm,
that's what I was worried about.  Main problem is that I can't easy 
compile kernel around version 5.5 because that always failed with this:

   HOSTLD  scripts/dtc/dtc
/usr/bin/ld: scripts/dtc/dtc-parser.tab.o:(.bss+0x20): multiple 
definition of `yylloc'; scripts/dtc/dtc-lexer.lex.o:(.bss+0x0): first 
defined here
collect2: error: ld returned 1 exit status
make[1]: *** [scripts/Makefile.host:116: scripts/dtc/dtc] Error 1
make: *** [Makefile:1260: scripts_dtc] Error 2
make: *** Waiting for unfinished jobs....

I solve this problem  copying  whole scripts dir from 5.5.14 where this 
issue was solved.
After this  git reset --hard and after this   git bisect good | bad.

Prepare with this:

git clone -o mainline --no-checkout \
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  linux/
cd  linux/
git remote add -t master stable \
   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
git checkout --detach v5.4


git bisect start
git bisect good v5.4
git bisect bad v5.5

On each iteration I do git reset --hard and copy sctipt direcotry.

Regards
                 Dan



Dne 13. 03. 24 v 12:43 Marc Kleine-Budde napsal(a):
> On 13.03.2024 12:22:25, Daniel Smolik wrote:
>> this is my first bisection please be lenient :-) Threse is a result:
>>
>> marvin@marvin:/usr/src/linux$ git bisect good
>> Bisecting: 0 revisions left to test after this (roughly 0 steps)
>> [52f96cd135b160d44db4cb62a5b614b3bca20fbc] net: stmmac: xgmac: Remove
>> uneeded computation for RFA/RFD
> I think you still miss a bisection step.
>
> The commit 52f96cd135b1 ("net: stmmac: xgmac: Remove uneeded computation
> for RFA/RFD") is unrelated to CAN problem you described. It's in the
> stmmac Ethernet driver.
>
> Marc
>