mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] wifi: rtw89: fix typos in comments, debug messages and struct field
@ 2026-09-04 22:25 Maxim Skokov
  2026-09-07  0:53 ` Ping-Ke Shih
  2026-09-08  6:34 ` Ping-Ke Shih
  0 siblings, 2 replies; 6+ messages in thread
From: Maxim Skokov @ 2026-09-04 22:25 UTC (permalink / raw)
  To: Ping-Ke Shih; +Cc: linux-wireless, linux-kernel, Maxim Skokov

Correct several misspellings found by codespell:

  moniter   -> monitor     (struct rtw89_btc_wl_role_info_bpos field)
  serach    -> search      (comment)
  Unsupport -> Unsupported (error message)
  nofity    -> notify      (comment)
  updat     -> update      (debug message)
  lagacy    -> legacy      (comment)

The renamed struct field has no users, so no further changes are
needed. No functional changes.

Signed-off-by: Maxim Skokov <skokovmaksimevg@gmail.com>
---

Notes:
    Found with codespell. Patch prepared with AI assistance; all changes reviewed by me.

 drivers/net/wireless/realtek/rtw89/core.h | 4 ++--
 drivers/net/wireless/realtek/rtw89/fw.c   | 4 ++--
 drivers/net/wireless/realtek/rtw89/phy.c  | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
index 2b21d969e..814f3b94c 100644
--- a/drivers/net/wireless/realtek/rtw89/core.h
+++ b/drivers/net/wireless/realtek/rtw89/core.h
@@ -1904,7 +1904,7 @@ struct rtw89_btc_wl_role_info_bpos {
 	u16 adhoc: 1;
 	u16 adhoc_master: 1;
 	u16 mesh: 1;
-	u16 moniter: 1;
+	u16 monitor: 1;
 	u16 p2p_device: 1;
 	u16 p2p_gc: 1;
 	u16 p2p_go: 1;
@@ -3925,7 +3925,7 @@ struct rtw89_btc_fddr_cell {
 struct rtw89_btc_fddr_result {
 	u8 wl_rx_limit;
 	u8 wl_rx_limit_step[6]; /* record search process */
-	u8 search_cnt; /* the rx-limit serach count */
+	u8 search_cnt; /* the rx-limit search count */
 	u32 wl_tp;
 	u32 wl_tp_step[6]; /* record search process */
 };
diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 0099c5c03..ecedfd6f6 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -306,7 +306,7 @@ static int __parse_formatted_mssc(struct rtw89_dev *rtwdev,
 		if (mss_hdr->defen)
 			rmp_tbl_size += FWDL_MSS_POOL_DEFKEYSETS_SIZE;
 	} else {
-		rtw89_err(rtwdev, "[ERR] MSS Key Pool Remap Table Format Unsupport:%X\n",
+		rtw89_err(rtwdev, "[ERR] MSS Key Pool Remap Table Format Unsupported:%X\n",
 			  mss_hdr->rmpfmt);
 		return -EINVAL;
 	}
@@ -11214,7 +11214,7 @@ int rtw89_fw_h2c_wow_request_aoac(struct rtw89_dev *rtwdev)
 
 	skb_put(skb, len);
 
-	/* This H2C only nofity firmware to generate AOAC report C2H,
+	/* This H2C only notify firmware to generate AOAC report C2H,
 	 * no need any parameter.
 	 */
 	rtw89_h2c_pkt_set_hdr(rtwdev, skb, FWCMD_TYPE_H2C,
diff --git a/drivers/net/wireless/realtek/rtw89/phy.c b/drivers/net/wireless/realtek/rtw89/phy.c
index c78107e92..43b3552f5 100644
--- a/drivers/net/wireless/realtek/rtw89/phy.c
+++ b/drivers/net/wireless/realtek/rtw89/phy.c
@@ -525,7 +525,7 @@ void rtw89_phy_ra_update_sta_link(struct rtw89_dev *rtwdev,
 		ra->upd_bw_nss_mask = 1;
 
 	rtw89_debug(rtwdev, RTW89_DBG_RA,
-		    "ra updat: macid = %d, bw = %d, nss = %d, gi = %d %d",
+		    "ra update: macid = %d, bw = %d, nss = %d, gi = %d %d",
 		    ra->macid,
 		    ra->bw_cap,
 		    ra->ss_num,
@@ -659,7 +659,7 @@ void __rtw89_phy_rate_pattern_vif(struct rtw89_dev *rtwdev,
 					  0, true))
 			goto out;
 
-	/* lagacy cannot be empty for nl80211_parse_tx_bitrate_mask, and
+	/* legacy cannot be empty for nl80211_parse_tx_bitrate_mask, and
 	 * require at least one basic rate for ieee80211_set_bitrate_mask,
 	 * so the decision just depends on if all bitrates are set or not.
 	 */
-- 
2.47.3


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] wifi: rtw89: fix typos in comments, debug messages and struct field
  2026-09-04 22:25 [PATCH] wifi: rtw89: fix typos in comments, debug messages and struct field Maxim Skokov
@ 2026-09-07  0:53 ` Ping-Ke Shih
  2026-09-07  4:00   ` Maxim Skokov
  2026-09-08  6:34 ` Ping-Ke Shih
  1 sibling, 1 reply; 6+ messages in thread
From: Ping-Ke Shih @ 2026-09-07  0:53 UTC (permalink / raw)
  To: Maxim Skokov; +Cc: linux-wireless, linux-kernel

Maxim Skokov <skokovmaksimevg@gmail.com> wrote:
> Correct several misspellings found by codespell:
> 
>   moniter   -> monitor     (struct rtw89_btc_wl_role_info_bpos field)
>   serach    -> search      (comment)
>   Unsupport -> Unsupported (error message)
>   nofity    -> notify      (comment)
>   updat     -> update      (debug message)
>   lagacy    -> legacy      (comment)
> 
> The renamed struct field has no users, so no further changes are
> needed. No functional changes.
> 
> Signed-off-by: Maxim Skokov <skokovmaksimevg@gmail.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>


> ---
> 
> Notes:
>     Found with codespell. Patch prepared with AI assistance; all changes reviewed by me.

Add a tag like  Assisted-by: LLM codespell ?

Just reply this mail, no need to resend v2. 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] wifi: rtw89: fix typos in comments, debug messages and struct field
  2026-09-07  0:53 ` Ping-Ke Shih
@ 2026-09-07  4:00   ` Maxim Skokov
  2026-09-07  4:20     ` Ping-Ke Shih
  0 siblings, 1 reply; 6+ messages in thread
From: Maxim Skokov @ 2026-09-07  4:00 UTC (permalink / raw)
  To: pkshih; +Cc: linux-wireless, linux-kernel

Ping-Ke Shih <pkshih@realtek.com> wrote:
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> Add a tag like  Assisted-by: LLM codespell ?
>
> Just reply this mail, no need to resend v2.

Yes, thanks, that is the right tag and it matches the format documented in
Documentation/process/coding-assistants.rst.  Please add:

Assisted-by: LLM codespell

The note below the --- line can be dropped, since the tag now says the same
thing in the commit message.

Thanks for the review.

Maxim

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] wifi: rtw89: fix typos in comments, debug messages and struct field
  2026-09-07  4:00   ` Maxim Skokov
@ 2026-09-07  4:20     ` Ping-Ke Shih
  2026-09-07  4:43       ` Maxim Skokov
  0 siblings, 1 reply; 6+ messages in thread
From: Ping-Ke Shih @ 2026-09-07  4:20 UTC (permalink / raw)
  To: Maxim Skokov; +Cc: linux-wireless, linux-kernel

Maxim Skokov <skokovmaksimevg@gmail.com> wrote:
> Ping-Ke Shih <pkshih@realtek.com> wrote:
> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> >
> > Add a tag like  Assisted-by: LLM codespell ?
> >
> > Just reply this mail, no need to resend v2.
> 
> Yes, thanks, that is the right tag and it matches the format documented in
> Documentation/process/coding-assistants.rst.  Please add:
> 
> Assisted-by: LLM codespell
> 

I think "LLM" should point out the model explicitly, such as
Claude:claude-opus-5, Codex:gpt-5.6-terra, ...



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] wifi: rtw89: fix typos in comments, debug messages and struct field
  2026-09-07  4:20     ` Ping-Ke Shih
@ 2026-09-07  4:43       ` Maxim Skokov
  0 siblings, 0 replies; 6+ messages in thread
From: Maxim Skokov @ 2026-09-07  4:43 UTC (permalink / raw)
  To: pkshih; +Cc: linux-wireless, linux-kernel

Ping-Ke Shih <pkshih@realtek.com> wrote:
> I think "LLM" should point out the model explicitly, such as
> Claude:claude-opus-5, Codex:gpt-5.6-terra, ...

Agreed, that is what commits in the tree already do. Please use:

Assisted-by: Claude:claude-opus-5 codespell

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] wifi: rtw89: fix typos in comments, debug messages and struct field
  2026-09-04 22:25 [PATCH] wifi: rtw89: fix typos in comments, debug messages and struct field Maxim Skokov
  2026-09-07  0:53 ` Ping-Ke Shih
@ 2026-09-08  6:34 ` Ping-Ke Shih
  1 sibling, 0 replies; 6+ messages in thread
From: Ping-Ke Shih @ 2026-09-08  6:34 UTC (permalink / raw)
  To: Maxim Skokov, Ping-Ke Shih; +Cc: linux-wireless, linux-kernel, Maxim Skokov

Maxim Skokov <skokovmaksimevg@gmail.com> wrote:

> Correct several misspellings found by codespell:
> 
>   moniter   -> monitor     (struct rtw89_btc_wl_role_info_bpos field)
>   serach    -> search      (comment)
>   Unsupport -> Unsupported (error message)
>   nofity    -> notify      (comment)
>   updat     -> update      (debug message)
>   lagacy    -> legacy      (comment)
> 
> The renamed struct field has no users, so no further changes are
> needed. No functional changes.
> 
> Signed-off-by: Maxim Skokov <skokovmaksimevg@gmail.com>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

f71dd599a981 wifi: rtw89: fix typos in comments, debug messages and struct field

---
https://github.com/pkshih/rtw.git


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-09-08  6:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-04 22:25 [PATCH] wifi: rtw89: fix typos in comments, debug messages and struct field Maxim Skokov
2026-09-07  0:53 ` Ping-Ke Shih
2026-09-07  4:00   ` Maxim Skokov
2026-09-07  4:20     ` Ping-Ke Shih
2026-09-07  4:43       ` Maxim Skokov
2026-09-08  6:34 ` Ping-Ke Shih

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®