From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jose Javier Rodriguez Barbarin
<dev-josejavier.rodriguez@duagon.com>,
linus.walleij@linaro.org, brgl@bgdev.pl
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Felipe Jensen Casado <felipe.jensen@duagon.com>
Subject: Re: [PATCH v2] gpio: menz127: add support for 16Z034 and 16Z037 GPIO controllers
Date: Wed, 12 Nov 2025 16:48:53 +0100 [thread overview]
Message-ID: <80a20b13-7c6a-4483-9741-568424f957ef@kernel.org> (raw)
In-Reply-To: <20251111161817.33310-1-dev-josejavier.rodriguez@duagon.com>
On 11/11/2025 17:18, Jose Javier Rodriguez Barbarin wrote:
>
> static const struct mcb_device_id men_z127_ids[] = {
> - { .device = 0x7f },
> + { .device = MEN_Z127_ID },
> + { .device = MEN_Z034_ID },
> + { .device = MEN_Z037_ID },
> { }
> };
> MODULE_DEVICE_TABLE(mcb, men_z127_ids);
> @@ -204,4 +224,6 @@ MODULE_AUTHOR("Andreas Werner <andreas.werner@men.de>");
> MODULE_DESCRIPTION("MEN 16z127 GPIO Controller");
> MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("mcb:16z127");
> +MODULE_ALIAS("mcb:16z034");
> +MODULE_ALIAS("mcb:16z037");
Why do you need these? You have MODULE_DEVICE_TABLE() just few lines above.
> MODULE_IMPORT_NS("MCB");
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-12 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 16:18 Jose Javier Rodriguez Barbarin
2025-11-12 15:48 ` Krzysztof Kozlowski [this message]
2025-11-17 13:38 ` Jose Javier Rodriguez Barbarin
2025-11-17 14:35 ` Krzysztof Kozlowski
2025-11-19 13:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80a20b13-7c6a-4483-9741-568424f957ef@kernel.org \
--to=krzk@kernel.org \
--cc=brgl@bgdev.pl \
--cc=dev-josejavier.rodriguez@duagon.com \
--cc=felipe.jensen@duagon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®