From: "Richard Genoud" <richard.genoud@gmail.com>
To: "Julia Lawall" <julia@diku.dk>
Cc: mchehab@infradead.org, v4l-dvb-maintainer@linuxtv.org,
video4linux-list@redhat.com, vigneshbabu@gmail.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/5] drivers/media/common/tuners: Drop code after return or goto
Date: Thu, 11 Sep 2008 15:46:35 +0200 [thread overview]
Message-ID: <80b317760809110646l6e0f678v2d17d9823653d642@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0809111433020.9593@pc-004.diku.dk>
2008/9/11 Julia Lawall <julia@diku.dk>:
> From: Julia Lawall <julia@diku.dk>
>
> The break after the return or goto serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> ---
> drivers/media/common/tuners/mxl5007t.c | 1 -
> drivers/media/common/tuners/tda18271-fe.c | 1 -
> drivers/media/common/tuners/tda9887.c | 1 -
> drivers/media/common/tuners/tuner-simple.c | 1 -
> 4 files changed, 4 deletions(-)
>
> diff -u -p a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
> --- a/drivers/media/common/tuners/tuner-simple.c
> +++ b/drivers/media/common/tuners/tuner-simple.c
> @@ -1038,7 +1038,6 @@ struct dvb_frontend *simple_tuner_attach
> case 0:
> mutex_unlock(&tuner_simple_list_mutex);
> return NULL;
> - break;
> case 1:
> fe->tuner_priv = priv;
>
> diff -u -p a/drivers/media/common/tuners/tda18271-fe.c b/drivers/media/common/tuners/tda18271-fe.c
> --- a/drivers/media/common/tuners/tda18271-fe.c
> +++ b/drivers/media/common/tuners/tda18271-fe.c
> @@ -1155,7 +1155,6 @@ struct dvb_frontend *tda18271_attach(str
> switch (instance) {
> case 0:
> goto fail;
> - break;
> case 1:
> /* new tuner instance */
> priv->gate = (cfg) ? cfg->gate : TDA18271_GATE_AUTO;
> diff -u -p a/drivers/media/common/tuners/mxl5007t.c b/drivers/media/common/tuners/mxl5007t.c
> --- a/drivers/media/common/tuners/mxl5007t.c
> +++ b/drivers/media/common/tuners/mxl5007t.c
> @@ -979,7 +979,6 @@ struct dvb_frontend *mxl5007t_attach(str
> switch (instance) {
> case 0:
> goto fail;
> - break;
> case 1:
> /* new tuner instance */
> state->config = cfg;
> diff -u -p a/drivers/media/common/tuners/tda9887.c b/drivers/media/common/tuners/tda9887.c
> --- a/drivers/media/common/tuners/tda9887.c
> +++ b/drivers/media/common/tuners/tda9887.c
> @@ -686,7 +686,6 @@ struct dvb_frontend *tda9887_attach(stru
> case 0:
> mutex_unlock(&tda9887_list_mutex);
> return NULL;
> - break;
> case 1:
> fe->analog_demod_priv = priv;
> priv->mode = T_STANDBY;
>
prev parent reply other threads:[~2008-09-11 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 12:33 Julia Lawall
2008-09-11 13:46 ` Richard Genoud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80b317760809110646l6e0f678v2d17d9823653d642@mail.gmail.com \
--to=richard.genoud@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
--cc=video4linux-list@redhat.com \
--cc=vigneshbabu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®