mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Richard Genoud" <richard.genoud@gmail.com>
To: "Julia Lawall" <julia@diku.dk>
Cc: chas@cmf.nrl.navy.mil, vigneshbabu@gmail.com,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/5] net/atm/lec.c: Drop code after return
Date: Thu, 11 Sep 2008 15:47:14 +0200	[thread overview]
Message-ID: <80b317760809110647w1659ceffia363cc55c295b631@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0809111433510.9593@pc-004.diku.dk>

2008/9/11 Julia Lawall <julia@diku.dk>:
> From: Julia Lawall <julia@diku.dk>
>
> The break after the return serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> ---
>
>  net/atm/lec.c                 |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/atm/lec.c b/net/atm/lec.c
> index 5799fb5..8f701cd 100644
> --- a/net/atm/lec.c
> +++ b/net/atm/lec.c
> @@ -1931,7 +1931,6 @@ static struct atm_vcc *lec_arp_resolve(struct lec_priv *priv,
>                switch (priv->lane_version) {
>                case 1:
>                        return priv->mcast_vcc;
> -                       break;
>                case 2: /* LANE2 wants arp for multicast addresses */
>                        if (!compare_ether_addr(mac_to_find, bus_mac))
>                                return priv->mcast_vcc;
>

      reply	other threads:[~2008-09-11 13:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-11 12:34 Julia Lawall
2008-09-11 13:47 ` Richard Genoud [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80b317760809110647w1659ceffia363cc55c295b631@mail.gmail.com \
    --to=richard.genoud@gmail.com \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vigneshbabu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®