* [PATCH 4/5] net/atm/lec.c: Drop code after return
@ 2008-09-11 12:34 Julia Lawall
2008-09-11 13:47 ` Richard Genoud
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2008-09-11 12:34 UTC (permalink / raw)
To: chas, vigneshbabu, richard.genoud, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The break after the return serves no purpose.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
net/atm/lec.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/atm/lec.c b/net/atm/lec.c
index 5799fb5..8f701cd 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -1931,7 +1931,6 @@ static struct atm_vcc *lec_arp_resolve(struct lec_priv *priv,
switch (priv->lane_version) {
case 1:
return priv->mcast_vcc;
- break;
case 2: /* LANE2 wants arp for multicast addresses */
if (!compare_ether_addr(mac_to_find, bus_mac))
return priv->mcast_vcc;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 4/5] net/atm/lec.c: Drop code after return
2008-09-11 12:34 [PATCH 4/5] net/atm/lec.c: Drop code after return Julia Lawall
@ 2008-09-11 13:47 ` Richard Genoud
0 siblings, 0 replies; 2+ messages in thread
From: Richard Genoud @ 2008-09-11 13:47 UTC (permalink / raw)
To: Julia Lawall; +Cc: chas, vigneshbabu, linux-kernel, kernel-janitors
2008/9/11 Julia Lawall <julia@diku.dk>:
> From: Julia Lawall <julia@diku.dk>
>
> The break after the return serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> ---
>
> net/atm/lec.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/atm/lec.c b/net/atm/lec.c
> index 5799fb5..8f701cd 100644
> --- a/net/atm/lec.c
> +++ b/net/atm/lec.c
> @@ -1931,7 +1931,6 @@ static struct atm_vcc *lec_arp_resolve(struct lec_priv *priv,
> switch (priv->lane_version) {
> case 1:
> return priv->mcast_vcc;
> - break;
> case 2: /* LANE2 wants arp for multicast addresses */
> if (!compare_ether_addr(mac_to_find, bus_mac))
> return priv->mcast_vcc;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-11 13:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-11 12:34 [PATCH 4/5] net/atm/lec.c: Drop code after return Julia Lawall
2008-09-11 13:47 ` Richard Genoud
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®