mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Richard Genoud" <richard.genoud@gmail.com>
To: "Julia Lawall" <julia@diku.dk>
Cc: maciej.sosnowski@intel.com, linux-kernel@vger.kernel.org,
	vigneshbabu@gmail.com, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 5/5] drivers/dma/ioat_dma.c: Drop code after return
Date: Thu, 11 Sep 2008 15:47:31 +0200	[thread overview]
Message-ID: <80b317760809110647wf1b81e3u799c63e0aa83a04@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0809111434100.9593@pc-004.diku.dk>

2008/9/11 Julia Lawall <julia@diku.dk>:
> From: Julia Lawall <julia@diku.dk>
>
> The break after the return serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> ---
>
>  drivers/dma/ioat_dma.c        |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
> index bc8c6e3..1ef68b3 100644
> --- a/drivers/dma/ioat_dma.c
> +++ b/drivers/dma/ioat_dma.c
> @@ -971,11 +971,9 @@ static struct ioat_desc_sw *ioat_dma_get_next_descriptor(
>        switch (ioat_chan->device->version) {
>        case IOAT_VER_1_2:
>                return ioat1_dma_get_next_descriptor(ioat_chan);
> -               break;
>        case IOAT_VER_2_0:
>        case IOAT_VER_3_0:
>                return ioat2_dma_get_next_descriptor(ioat_chan);
> -               break;
>        }
>        return NULL;
>  }
>

  reply	other threads:[~2008-09-11 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-11 12:34 Julia Lawall
2008-09-11 13:47 ` Richard Genoud [this message]
2008-09-12 12:13 ` Sosnowski, Maciej

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80b317760809110647wf1b81e3u799c63e0aa83a04@mail.gmail.com \
    --to=richard.genoud@gmail.com \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.sosnowski@intel.com \
    --cc=vigneshbabu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®