* [PATCH 5/5] drivers/dma/ioat_dma.c: Drop code after return
@ 2008-09-11 12:34 Julia Lawall
2008-09-11 13:47 ` Richard Genoud
2008-09-12 12:13 ` Sosnowski, Maciej
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2008-09-11 12:34 UTC (permalink / raw)
To: maciej.sosnowski, linux-kernel, vigneshbabu, richard.genoud,
linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The break after the return serves no purpose.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/dma/ioat_dma.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
index bc8c6e3..1ef68b3 100644
--- a/drivers/dma/ioat_dma.c
+++ b/drivers/dma/ioat_dma.c
@@ -971,11 +971,9 @@ static struct ioat_desc_sw *ioat_dma_get_next_descriptor(
switch (ioat_chan->device->version) {
case IOAT_VER_1_2:
return ioat1_dma_get_next_descriptor(ioat_chan);
- break;
case IOAT_VER_2_0:
case IOAT_VER_3_0:
return ioat2_dma_get_next_descriptor(ioat_chan);
- break;
}
return NULL;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 5/5] drivers/dma/ioat_dma.c: Drop code after return
2008-09-11 12:34 [PATCH 5/5] drivers/dma/ioat_dma.c: Drop code after return Julia Lawall
@ 2008-09-11 13:47 ` Richard Genoud
2008-09-12 12:13 ` Sosnowski, Maciej
1 sibling, 0 replies; 3+ messages in thread
From: Richard Genoud @ 2008-09-11 13:47 UTC (permalink / raw)
To: Julia Lawall; +Cc: maciej.sosnowski, linux-kernel, vigneshbabu, kernel-janitors
2008/9/11 Julia Lawall <julia@diku.dk>:
> From: Julia Lawall <julia@diku.dk>
>
> The break after the return serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> ---
>
> drivers/dma/ioat_dma.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
> index bc8c6e3..1ef68b3 100644
> --- a/drivers/dma/ioat_dma.c
> +++ b/drivers/dma/ioat_dma.c
> @@ -971,11 +971,9 @@ static struct ioat_desc_sw *ioat_dma_get_next_descriptor(
> switch (ioat_chan->device->version) {
> case IOAT_VER_1_2:
> return ioat1_dma_get_next_descriptor(ioat_chan);
> - break;
> case IOAT_VER_2_0:
> case IOAT_VER_3_0:
> return ioat2_dma_get_next_descriptor(ioat_chan);
> - break;
> }
> return NULL;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH 5/5] drivers/dma/ioat_dma.c: Drop code after return
2008-09-11 12:34 [PATCH 5/5] drivers/dma/ioat_dma.c: Drop code after return Julia Lawall
2008-09-11 13:47 ` Richard Genoud
@ 2008-09-12 12:13 ` Sosnowski, Maciej
1 sibling, 0 replies; 3+ messages in thread
From: Sosnowski, Maciej @ 2008-09-12 12:13 UTC (permalink / raw)
To: Julia Lawall
Cc: linux-kernel, vigneshbabu, richard.genoud, linux-kernel, kernel-janitors
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The break after the return serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
>
> drivers/dma/ioat_dma.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
> index bc8c6e3..1ef68b3 100644
> --- a/drivers/dma/ioat_dma.c
> +++ b/drivers/dma/ioat_dma.c
> @@ -971,11 +971,9 @@ static struct ioat_desc_sw
> *ioat_dma_get_next_descriptor( switch
(ioat_chan->device->version) {
> case IOAT_VER_1_2:
> return ioat1_dma_get_next_descriptor(ioat_chan);
> - break;
> case IOAT_VER_2_0:
> case IOAT_VER_3_0:
> return ioat2_dma_get_next_descriptor(ioat_chan);
> - break;
> }
> return NULL;
> }
You are right. Thanks for pointing this out.
Acked-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-12 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-11 12:34 [PATCH 5/5] drivers/dma/ioat_dma.c: Drop code after return Julia Lawall
2008-09-11 13:47 ` Richard Genoud
2008-09-12 12:13 ` Sosnowski, Maciej
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®