[PATCH v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC

[PATCH v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC

[Janaki Ramaiah Thota]

This change is done to align the settling time and
synchronization for baudrate VSC for WCN6750.

In logging disabled builds and few devices
baudrate change and flow control is taking time
so increasing the wait time to controller and uart
to handle baudrate change request properly.

Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
---
 drivers/bluetooth/hci_qca.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 0c9c9ee56592..667687835306 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1356,12 +1356,15 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
 	case QCA_WCN3990:
 	case QCA_WCN3991:
 	case QCA_WCN3998:
-	case QCA_WCN6750:
 	case QCA_WCN6855:
 	case QCA_WCN7850:
 		usleep_range(1000, 10000);
 		break;
 
+	case QCA_WCN6750:
+		msleep(30);
+		break;
+
 	default:
 		msleep(300);
 	}
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC

[Paul Menzel]

Dear Janaki,


Thank you for your patch. Please be more specific in the summary/title:

> Increase settling time for baudrate change VSC to 30 ms


Am 17.06.24 um 09:00 schrieb Janaki Ramaiah Thota:
> This change is done to align the settling time and
> synchronization for baudrate VSC for WCN6750.
> 
> In logging disabled builds and few devices
> baudrate change and flow control is taking time
> so increasing the wait time to controller and uart
> to handle baudrate change request properly.

Is the 30 ms documented in some datasheet?

Please use 75 characters per line.

Please document the test system.

> Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
> ---
>   drivers/bluetooth/hci_qca.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 0c9c9ee56592..667687835306 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1356,12 +1356,15 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
>   	case QCA_WCN3990:
>   	case QCA_WCN3991:
>   	case QCA_WCN3998:
> -	case QCA_WCN6750:
>   	case QCA_WCN6855:
>   	case QCA_WCN7850:
>   		usleep_range(1000, 10000);
>   		break;
>   
> +	case QCA_WCN6750:
> +		msleep(30);

Why not usleep_range?

> +		break;
> +
>   	default:
>   		msleep(300);
>   	}


Kind regards,

Paul

[PATCH] PENDING: Bluetooth: Increase settling time for baudrate change VSC

[Janaki Ramaiah Thota]

From: Harish Bandi <quic_hbandi@quicinc.com>

This change is done to align the settling time and
synchronization for baudrate VSC for WCN6750.

In logging disabled builds and few devices
baudrate change and flow control is taking time
so increasing the wait time to controller and uart
to handle baudrate change request properly.

Change-Id: If0631cb886e53817f963f075e626c89a791b7be4
Signed-off-by: Harish Bandi <quic_hbandi@quicinc.com>
---

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index eba9165..a59b35e 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -600,7 +600,6 @@
 		rom_ver = ((soc_ver & 0x00000f00) >> 0x04) | (soc_ver & 0x0000000f);
 
 	if (soc_type == QCA_WCN6750) {
-		msleep(100);
 		qca_send_patch_config_cmd(hdev);
 	}
 
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index d8abd27..0b41214 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1356,11 +1356,13 @@
 	case QCA_WCN3990:
 	case QCA_WCN3991:
 	case QCA_WCN3998:
-	case QCA_WCN6750:
 	case QCA_WCN6855:
 	case QCA_WCN7850:
 		usleep_range(1000, 10000);
 		break;
+	case QCA_WCN6750:
+		msleep(30);
+		break;
 
 	default:
 		msleep(300);
@@ -1904,7 +1906,6 @@
 		qca_set_speed(hu, QCA_INIT_SPEED);
 	}
 
-	usleep_range(1000, 20000);
 	/* Setup user speed if needed */
 	speed = qca_get_speed(hu, QCA_OPER_SPEED);
 	if (speed) {

[PATCH v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC

[Janaki Ramaiah Thota]

This change is done to align the settling time and
synchronization for baudrate VSC for WCN6750.

In logging disabled builds and few devices
baudrate change and flow control is taking time
so increasing the wait time to controller and uart
to handle baudrate change request properly.

Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
---
 drivers/bluetooth/hci_qca.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 0c9c9ee56592..667687835306 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1356,12 +1356,15 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
 	case QCA_WCN3990:
 	case QCA_WCN3991:
 	case QCA_WCN3998:
-	case QCA_WCN6750:
 	case QCA_WCN6855:
 	case QCA_WCN7850:
 		usleep_range(1000, 10000);
 		break;
 
+	case QCA_WCN6750:
+		msleep(30);
+		break;
+
 	default:
 		msleep(300);
 	}
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project