From: Siddh Raman Pant <siddh.raman.pant@oracle.com>
To: "cem@kernel.org" <cem@kernel.org>
Cc: "djwong@kernel.org" <djwong@kernel.org>,
"dchinner@redhat.com" <dchinner@redhat.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] xfs: Fix duplicate assignment in xfs_alloc_read_agf.
Date: Wed, 21 Oct 2026 12:16:25 +0000 [thread overview]
Message-ID: <8104ae683f89ff3415528198c8b4af0089b7f9fa.camel@oracle.com> (raw)
In-Reply-To: <atirYb9qxRsaRYhs@cronus.toxiclabs.cc>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
Probably an (harmless) error in copy-paste.
Fixes: db6a2274162d ("xfs: catch stale AGF/AGF metadata")
Cc: stable@vger.kernel.org # v5.10
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com>
---
fs/xfs/libxfs/xfs_alloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index f762dcce8d13..0ffa82400007 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -3461,7 +3461,6 @@ xfs_alloc_read_agf(
if (!xfs_is_shutdown(pag_mount(pag))) {
bool ok = true;
- ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
ok &= pag->pagf_btreeblks == be32_to_cpu(agf->agf_btreeblks);
ok &= pag->pagf_flcount == be32_to_cpu(agf->agf_flcount);
--
2.53.0
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-10-21 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 14:51 [PATCH] " Siddh Raman Pant
2026-10-01 14:58 ` Darrick J. Wong
2026-10-13 14:31 ` Carlos Maiolino
2026-10-13 14:33 ` Darrick J. Wong
2026-10-15 12:56 ` Siddh Raman Pant
2026-10-21 12:11 ` Carlos Maiolino
2026-10-21 12:16 ` Siddh Raman Pant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8104ae683f89ff3415528198c8b4af0089b7f9fa.camel@oracle.com \
--to=siddh.raman.pant@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®