mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Insu Yun <wuninsu@gmail.com>
Cc: dhowells@redhat.com, james.l.morris@oracle.com, serge@hallyn.com,
	keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, taesoo@gatech.edu,
	yeongjin.jang@gatech.edu, insu@gatech.edu
Subject: Re: [PATCH] keys: change member variable name
Date: Thu, 15 Oct 2015 22:58:04 +0100	[thread overview]
Message-ID: <8109.1444946284@warthog.procyon.org.uk> (raw)
In-Reply-To: <1444945400-31465-1-git-send-email-wuninsu@gmail.com>

Insu Yun <wuninsu@gmail.com> wrote:

> key->description and key->index_key.description are same because 
> they are unioned. But, for readability, using same name for
> duplication and validation seems better.
> 
> Signed-off-by: Insu Yun <wuninsu@gmail.com>

I've applied this, but I've changed the subject line to:

	keys: Be more consistent in selection of union members used

if you're okay with that.

David

      reply	other threads:[~2015-10-15 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 21:43 Insu Yun
2015-10-15 21:58 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8109.1444946284@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=insu@gatech.edu \
    --cc=james.l.morris@oracle.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=taesoo@gatech.edu \
    --cc=wuninsu@gmail.com \
    --cc=yeongjin.jang@gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®