From: Philipp Stanner <phasta@mailbox.org>
To: Markus Elfring <Markus.Elfring@web.de>,
Qianyi Liu <liuqianyi125@gmail.com>,
dri-devel@lists.freedesktop.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Danilo Krummrich" <dakr@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Philipp Stanner" <phasta@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH] drm/scheduler: Fix mem leak when last_scheduled signaled
Date: Tue, 25 Feb 2025 15:05:41 +0100 [thread overview]
Message-ID: <811ba40a31484ca5db4b0c380b9e67bec6517e4b.camel@mailbox.org> (raw)
In-Reply-To: <bc3ae5a6-9b04-4f1b-9045-2182138f748e@web.de>
On Tue, 2025-02-25 at 15:00 +0100, Markus Elfring wrote:
> > Problem: If prev(last_scheduled) was already signaled I encountred
> > a
>
> signalled?
> encountered?
>
>
> > memory leak in drm_sched_entity_fini. This is because the
> > prev(last_scheduled) fence is not free properly.
>
> freed?
>
>
> > Fix: Balance the prev(last_scheduled) fence refcnt when
> …
> reference count?
>
>
> Would a summary phrase like “Fix memory leak when last_scheduled
> signalled”
> be more appropriate?
>
>
> How do you think about to add any tags (like “Fixes” and “Cc”)
> accordingly?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc4#n145
>
He has already addressed that in v2.
https://lore.kernel.org/all/20250225094125.224580-1-liuqianyi125@gmail.com/
Besides, Matthew and I made those remarks already here in v1.
P.
> Regards,
> Markus
prev parent reply other threads:[~2025-02-25 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 6:27 qianyi liu
2025-02-24 9:52 ` Philipp Stanner
2025-02-24 9:57 ` Philipp Stanner
2025-02-25 2:58 ` Qianyi Liu
2025-02-25 3:12 ` Qianyi Liu
2025-02-25 7:23 ` Philipp Stanner
2025-02-25 5:46 ` Matthew Brost
2025-02-25 8:19 ` Qianyi Liu
2025-02-25 7:18 ` Philipp Stanner
2025-02-25 13:09 ` Qianyi Liu
2025-02-25 14:00 ` Markus Elfring
2025-02-25 14:05 ` Philipp Stanner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=811ba40a31484ca5db4b0c380b9e67bec6517e4b.camel@mailbox.org \
--to=phasta@mailbox.org \
--cc=Markus.Elfring@web.de \
--cc=airlied@gmail.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuqianyi125@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=phasta@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®