mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: gengdongjiu <gengdongjiu@huawei.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Borislav Petkov <bp@suse.de>, "Len Brown" <lenb@kernel.org>,
	Tyler Baicar <tbaicar@codeaurora.org>,
	Will Deacon <will.deacon@arm.com>,
	Prarit Bhargava <prarit@redhat.com>,
	"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type
Date: Sun, 22 Oct 2017 18:18:03 +0800	[thread overview]
Message-ID: <812042fc-bbf2-6bbb-8d5c-be32851005a1@huawei.com> (raw)
In-Reply-To: <CAJZ5v0gAGv2XSfvqx7Dyu1w8csUmoJ96wR667WZp4Dq_beyKHw@mail.gmail.com>



On 2017/10/22 17:38, Rafael J. Wysocki wrote:
> On Sun, Oct 22, 2017 at 8:54 AM, Dongjiu Geng <gengdongjiu@huawei.com> wrote:
>> For the SEA notification, the two functions ghes_sea_add() and
>> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
>> is defined. If not, it will return errors in the ghes_probe()
>> and not continue. If the probe is failed, the ghes_sea_remove()
>> also has no chance to be called. Hence, remove the unnecessary
>> handling when CONFIG_ACPI_APEI_SEA is not defined.
>>
>> For the NMI notification, it has the same issue as SEA notification,
>> so also remove the unused dead-code for it.
>>
>> Cc: Tyler Baicar <tbaicar@codeaurora.org>
>> Cc: James Morse <james.morse@arm.com>
>> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
>> Tested-by: Tyler Baicar <tbaicar@codeaurora.org>
>> Reviewed-by: Borislav Petkov <bp@suse.de>
> I applied one of the previous iterations.
> 
> Do I need to replace it with this version?

Rafael, I checked your applying, your applying is right. so no need to replace.
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=3275fe60d1138e0cb57be9a3f46306b4d031c643
which is already "Reviewed-by: Borislav Petkov <bp@suse.de>"
Thanks

> 

      parent reply	other threads:[~2017-10-22 10:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-22  6:54 Dongjiu Geng
2017-10-22  9:38 ` Rafael J. Wysocki
2017-10-22 10:06   ` gengdongjiu
2017-10-22 10:39     ` Borislav Petkov
2017-10-22 10:18   ` gengdongjiu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=812042fc-bbf2-6bbb-8d5c-be32851005a1@huawei.com \
    --to=gengdongjiu@huawei.com \
    --cc=bp@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tbaicar@codeaurora.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®