Re: [PATCH v3 30/30] gpu: nova-core: clarify the GPU firmware boot steps

[John Hubbard <jhubbard@nvidia.com>]

On 2/8/26 6:14 PM, John Hubbard wrote:
> On 2/6/26 10:43 AM, Timur Tabi wrote:
>> On Thu, 2026-02-05 at 20:21 -0800, John Hubbard wrote:
>>> +        // Reset and boot GSP before SEC2
>>> +        gsp_falcon.reset(bar)?;
>>> +        let libos_handle = libos.dma_handle();
>>> +        let (mbox0, mbox1) = gsp_falcon.boot(
>>> +            bar,
>>> +            Some(libos_handle as u32),
>>> +            Some((libos_handle >> 32) as u32),
>>> +        )?;
>>> +        dev_dbg!(dev, "GSP MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1);
>>> +        dev_dbg!(
>>> +            dev,
>>> +            "Using SEC2 to load and run the booter_load firmware...\n"
>>> +        );
>>> +
>>
>> Looks like you accidentally deleted the "if mbox0 != 0" test.
>>
> 
> OK, I've added it back in for the next version:
> ...

ah, *correction*, I spoke too quickly. The reason I removed any
such checks at some point is that they are wrong. This mailbox
contains the libos address after boot, not an error code.

Open RM also does not check.

thanks,
-- 
John Hubbard