mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
To: "idryomov@gmail.com" <idryomov@gmail.com>,
	"kexinsun@smail.nju.edu.cn" <kexinsun@smail.nju.edu.cn>
Cc: "ratnadiraw@smu.edu.sg" <ratnadiraw@smu.edu.sg>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"julia.lawall@inria.fr" <julia.lawall@inria.fr>,
	Alex Markuze <amarkuze@redhat.com>,
	"slava@dubeyko.com" <slava@dubeyko.com>,
	"xutong.ma@inria.fr" <xutong.ma@inria.fr>,
	"yunbolyu@smu.edu.sg" <yunbolyu@smu.edu.sg>
Subject: Re:  [PATCH] net/ceph: update outdated comment
Date: Tue, 24 Feb 2026 00:46:37 +0000	[thread overview]
Message-ID: <813085a960ca0fdff633236cbc0e5a6f3026b111.camel@ibm.com> (raw)
In-Reply-To: <20260223131507.901-1-kexinsun@smail.nju.edu.cn>

On Mon, 2026-02-23 at 21:15 +0800, kexinsun@smail.nju.edu.cn wrote:
> From: kexinsun <kexinsun@smail.nju.edu.cn>
> 
> The function try_write() was renamed to ceph_con_v1_try_write()
> in commit 566050e17e53 ("libceph: separate msgr1 protocol
> implementation") and subsequently moved to net/ceph/messenger_v1.c
> in commit 2f713615ddd9 ("libceph: move msgr1 protocol implementation
> to its own file").  Update the comment in ceph_sock_write_space()
> accordingly.
> 
> Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
> ---
>  net/ceph/messenger.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
> index 108adb583744..a041725ddedf 100644
> --- a/net/ceph/messenger.c
> +++ b/net/ceph/messenger.c
> @@ -368,8 +368,8 @@ static void ceph_sock_write_space(struct sock *sk)
>  	/* only queue to workqueue if there is data we want to write,
>  	 * and there is sufficient space in the socket buffer to accept
>  	 * more data.  clear SOCK_NOSPACE so that ceph_sock_write_space()
> -	 * doesn't get called again until try_write() fills the socket
> -	 * buffer. See net/ipv4/tcp_input.c:tcp_check_space()
> +	 * doesn't get called again until ceph_con_v1_try_write() fills 
> +	 * the socket buffer. See net/ipv4/tcp_input.c:tcp_check_space()
>  	 * and net/core/stream.c:sk_stream_write_space().
>  	 */
>  	if (ceph_con_flag_test(con, CEPH_CON_F_WRITE_PENDING)) {

Makes sense to me.

Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>

Thanks,
Slava.

      reply	other threads:[~2026-02-24  0:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 13:15 kexinsun
2026-02-24  0:46 ` Viacheslav Dubeyko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=813085a960ca0fdff633236cbc0e5a6f3026b111.camel@ibm.com \
    --to=slava.dubeyko@ibm.com \
    --cc=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=julia.lawall@inria.fr \
    --cc=kexinsun@smail.nju.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ratnadiraw@smu.edu.sg \
    --cc=slava@dubeyko.com \
    --cc=xutong.ma@inria.fr \
    --cc=yunbolyu@smu.edu.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®