[PATCH] net/ceph: update outdated comment

[PATCH] net/ceph: update outdated comment

[kexinsun]

From: kexinsun <kexinsun@smail.nju.edu.cn>

The function try_write() was renamed to ceph_con_v1_try_write()
in commit 566050e17e53 ("libceph: separate msgr1 protocol
implementation") and subsequently moved to net/ceph/messenger_v1.c
in commit 2f713615ddd9 ("libceph: move msgr1 protocol implementation
to its own file").  Update the comment in ceph_sock_write_space()
accordingly.

Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
---
 net/ceph/messenger.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
index 108adb583744..a041725ddedf 100644
--- a/net/ceph/messenger.c
+++ b/net/ceph/messenger.c
@@ -368,8 +368,8 @@ static void ceph_sock_write_space(struct sock *sk)
 	/* only queue to workqueue if there is data we want to write,
 	 * and there is sufficient space in the socket buffer to accept
 	 * more data.  clear SOCK_NOSPACE so that ceph_sock_write_space()
-	 * doesn't get called again until try_write() fills the socket
-	 * buffer. See net/ipv4/tcp_input.c:tcp_check_space()
+	 * doesn't get called again until ceph_con_v1_try_write() fills 
+	 * the socket buffer. See net/ipv4/tcp_input.c:tcp_check_space()
 	 * and net/core/stream.c:sk_stream_write_space().
 	 */
 	if (ceph_con_flag_test(con, CEPH_CON_F_WRITE_PENDING)) {
-- 
2.25.1

Re: [PATCH] net/ceph: update outdated comment

[Viacheslav Dubeyko]

On Mon, 2026-02-23 at 21:15 +0800, kexinsun@smail.nju.edu.cn wrote:
> From: kexinsun <kexinsun@smail.nju.edu.cn>
> 
> The function try_write() was renamed to ceph_con_v1_try_write()
> in commit 566050e17e53 ("libceph: separate msgr1 protocol
> implementation") and subsequently moved to net/ceph/messenger_v1.c
> in commit 2f713615ddd9 ("libceph: move msgr1 protocol implementation
> to its own file").  Update the comment in ceph_sock_write_space()
> accordingly.
> 
> Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
> ---
>  net/ceph/messenger.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
> index 108adb583744..a041725ddedf 100644
> --- a/net/ceph/messenger.c
> +++ b/net/ceph/messenger.c
> @@ -368,8 +368,8 @@ static void ceph_sock_write_space(struct sock *sk)
>  	/* only queue to workqueue if there is data we want to write,
>  	 * and there is sufficient space in the socket buffer to accept
>  	 * more data.  clear SOCK_NOSPACE so that ceph_sock_write_space()
> -	 * doesn't get called again until try_write() fills the socket
> -	 * buffer. See net/ipv4/tcp_input.c:tcp_check_space()
> +	 * doesn't get called again until ceph_con_v1_try_write() fills 
> +	 * the socket buffer. See net/ipv4/tcp_input.c:tcp_check_space()
>  	 * and net/core/stream.c:sk_stream_write_space().
>  	 */
>  	if (ceph_con_flag_test(con, CEPH_CON_F_WRITE_PENDING)) {

Makes sense to me.

Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>

Thanks,
Slava.