From: Md Danish Anwar <a0501179@ti.com>
To: Rob Herring <robh@kernel.org>, MD Danish Anwar <danishanwar@ti.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Roger Quadros <rogerq@kernel.org>,
Simon Horman <simon.horman@corigine.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
Richard Cochran <richardcochran@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>, <nm@ti.com>,
<srk@ti.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXTERNAL] Re: [PATCH v2 2/5] dt-bindings: net: Add iep property in ICSSG dt binding
Date: Tue, 22 Aug 2023 15:29:06 +0530 [thread overview]
Message-ID: <81330882-e8bc-558c-f1bf-9a10108973af@ti.com> (raw)
In-Reply-To: <20230821160120.GA1734560-robh@kernel.org>
Hi Rob,
On 21/08/23 9:31 pm, Rob Herring wrote:
> On Mon, Aug 07, 2023 at 04:30:45PM +0530, MD Danish Anwar wrote:
>> Add iep node in ICSSG driver dt binding document.
>
> Why?
>
> Bindings are for h/w, not drivers. You are adding a property, not a
I will change the above to "Add IEP property in ICSSG hardware DT binding
document."
> node. Would be nice to know what 'iep' is without having to look at the
> diff (e.g. when running 'git log').
>
Sure, I will provide description of IEP in the commit message.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>> Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> index 8ec30b3eb760..36870238f92f 100644
>> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> @@ -52,6 +52,12 @@ properties:
>> description:
>> phandle to MII_RT module's syscon regmap
>>
>> + ti,iep:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>
> phandle-array really means matrix, so you need to fully describe the
> items constraints.
>
>> + maxItems: 2
>
> 2 phandles or 1 phandle and 1 arg? Looks like the former from the
It's 2 phandles.
> example, so:
>
> maxItems: 2
> items:
> maxItems: 1
>
Sure, I will change the item constraints to above.
>> + description:
>> + phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver
>> +
>> interrupts:
>> maxItems: 2
>> description:
>> @@ -155,6 +161,7 @@ examples:
>> "tx1-0", "tx1-1", "tx1-2", "tx1-3",
>> "rx0", "rx1";
>> ti,mii-g-rt = <&icssg2_mii_g_rt>;
>> + ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
>> interrupt-parent = <&icssg2_intc>;
>> interrupts = <24 0 2>, <25 1 3>;
>> interrupt-names = "tx_ts0", "tx_ts1";
>> --
>> 2.34.1
>>
--
Thanks and Regards,
Danish.
next prev parent reply other threads:[~2023-08-22 9:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 11:00 [PATCH v2 0/5] Introduce IEP driver and packet timestamping support MD Danish Anwar
2023-08-07 11:00 ` [PATCH v2 1/5] dt-bindings: net: Add ICSS IEP MD Danish Anwar
2023-08-07 11:00 ` [PATCH v2 2/5] dt-bindings: net: Add iep property in ICSSG dt binding MD Danish Anwar
2023-08-08 10:42 ` Roger Quadros
2023-08-08 12:53 ` Md Danish Anwar
2023-08-21 16:01 ` Rob Herring
2023-08-22 9:59 ` Md Danish Anwar [this message]
2023-08-22 10:55 ` [EXTERNAL] " Md Danish Anwar
2023-08-07 11:00 ` [PATCH v2 3/5] net: ti: icss-iep: Add IEP driver MD Danish Anwar
2023-08-07 11:00 ` [PATCH v2 4/5] net: ti: icssg-prueth: add packet timestamping and ptp support MD Danish Anwar
2023-08-08 10:54 ` Roger Quadros
2023-08-08 13:09 ` Md Danish Anwar
2023-08-07 11:00 ` [PATCH v2 5/5] net: ti: icssg-prueth: am65x SR2.0 add 10M full duplex support MD Danish Anwar
2023-08-07 14:25 ` Andrew Lunn
2023-08-08 5:13 ` Md Danish Anwar
2023-08-08 11:14 ` Roger Quadros
2023-08-08 13:10 ` Md Danish Anwar
2023-08-08 12:08 ` [PATCH v2 0/5] Introduce IEP driver and packet timestamping support Conor Dooley
2023-08-08 12:18 ` [EXTERNAL] " Md Danish Anwar
2023-08-08 12:22 ` Roger Quadros
2023-08-08 12:36 ` Md Danish Anwar
2023-08-08 12:45 ` Conor Dooley
2023-08-09 5:01 ` Md Danish Anwar
2023-08-09 6:33 ` Md Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81330882-e8bc-558c-f1bf-9a10108973af@ti.com \
--to=a0501179@ti.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=simon.horman@corigine.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®