From: Md Danish Anwar <a0501179@ti.com>
To: Andrew Lunn <andrew@lunn.ch>, MD Danish Anwar <danishanwar@ti.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Roger Quadros <rogerq@kernel.org>,
Simon Horman <simon.horman@corigine.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Richard Cochran <richardcochran@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>, <nm@ti.com>,
<srk@ti.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 5/5] net: ti: icssg-prueth: am65x SR2.0 add 10M full duplex support
Date: Tue, 8 Aug 2023 10:43:05 +0530 [thread overview]
Message-ID: <a0e2b828-36c9-326b-9247-863bb62b760f@ti.com> (raw)
In-Reply-To: <dd0e538a-9369-4682-8eda-753d7cb83fb1@lunn.ch>
On 07/08/23 7:55 pm, Andrew Lunn wrote:
>> @@ -210,6 +210,9 @@ void icssg_config_ipg(struct prueth_emac *emac)
>> case SPEED_100:
>> icssg_mii_update_ipg(prueth->mii_rt, slice, MII_RT_TX_IPG_100M);
>> break;
>> + case SPEED_10:
>> + icssg_mii_update_ipg(prueth->mii_rt, slice, MII_RT_TX_IPG_100M);
>> + break;
>
> Since that looks like a typO, you might want to add a comment.
>
> Adnrew
Sure, Andrew. I'll add the below comment in 'case SPEED_10' so that it doesn't
seem like a typo.
case SPEED_10:
/* IPG for 10M is same as 100M */
icssg_mii_update_ipg(prueth->mii_rt, slice, MII_RT_TX_IPG_100M);
break;
--
Thanks and Regards,
Danish.
next prev parent reply other threads:[~2023-08-08 20:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 11:00 [PATCH v2 0/5] Introduce IEP driver and packet timestamping support MD Danish Anwar
2023-08-07 11:00 ` [PATCH v2 1/5] dt-bindings: net: Add ICSS IEP MD Danish Anwar
2023-08-07 11:00 ` [PATCH v2 2/5] dt-bindings: net: Add iep property in ICSSG dt binding MD Danish Anwar
2023-08-08 10:42 ` Roger Quadros
2023-08-08 12:53 ` Md Danish Anwar
2023-08-21 16:01 ` Rob Herring
2023-08-22 9:59 ` [EXTERNAL] " Md Danish Anwar
2023-08-22 10:55 ` Md Danish Anwar
2023-08-07 11:00 ` [PATCH v2 3/5] net: ti: icss-iep: Add IEP driver MD Danish Anwar
2023-08-07 11:00 ` [PATCH v2 4/5] net: ti: icssg-prueth: add packet timestamping and ptp support MD Danish Anwar
2023-08-08 10:54 ` Roger Quadros
2023-08-08 13:09 ` Md Danish Anwar
2023-08-07 11:00 ` [PATCH v2 5/5] net: ti: icssg-prueth: am65x SR2.0 add 10M full duplex support MD Danish Anwar
2023-08-07 14:25 ` Andrew Lunn
2023-08-08 5:13 ` Md Danish Anwar [this message]
2023-08-08 11:14 ` Roger Quadros
2023-08-08 13:10 ` Md Danish Anwar
2023-08-08 12:08 ` [PATCH v2 0/5] Introduce IEP driver and packet timestamping support Conor Dooley
2023-08-08 12:18 ` [EXTERNAL] " Md Danish Anwar
2023-08-08 12:22 ` Roger Quadros
2023-08-08 12:36 ` Md Danish Anwar
2023-08-08 12:45 ` Conor Dooley
2023-08-09 5:01 ` Md Danish Anwar
2023-08-09 6:33 ` Md Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0e2b828-36c9-326b-9247-863bb62b760f@ti.com \
--to=a0501179@ti.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=simon.horman@corigine.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®