From: Dan Murphy <dmurphy@ti.com>
To: Camel Guo <camel.guo@axis.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <tiwai@suse.com>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<kernel@axis.com>, Camel Guo <camelg@axis.com>
Subject: Re: [PATCH 2/2] ASoC: tlv320adcx140: Wake up codec before accessing register
Date: Tue, 8 Sep 2020 09:58:55 -0500 [thread overview]
Message-ID: <8160bf81-a72d-2db0-0767-79b0509ff143@ti.com> (raw)
In-Reply-To: <89f8cce0-2407-15f5-a8e5-0aa17a2eb2c4@ti.com>
Camel
On 9/8/20 6:49 AM, Dan Murphy wrote:
> Camel
>
> On 9/8/20 3:35 AM, Camel Guo wrote:
>> From: Camel Guo <camelg@axis.com>
>>
>> According to its datasheet, after reset this codec goes into sleep
>> mode. In this mode, any register accessing should be avoided except for
>> exiting sleep mode. Hence this commit moves SLEEP_CFG access before any
>> register accessing.
>
> This is interesting because our HW team suggested putting the device
> into sleep mode when doing register writes/reads because they were
> finding abnormalities in the register settings when the device is active.
>
> I have a local patch that changes this as well that the HW team
> requested.
OK I have clarification on this now. Their original request was
incorrect they indicate the BIAS, ADC and PLLs be powered down during
writes and reads.
>
> Mark
>
> Let me run this by the HW team first before applying this patch.
Mark
Acked-by: Dan Murphy <dmurphy@ti.com>
>
> Dan
>
next prev parent reply other threads:[~2020-09-08 16:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 8:35 [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset Camel Guo
2020-09-08 8:35 ` [PATCH 2/2] ASoC: tlv320adcx140: Wake up codec before accessing register Camel Guo
2020-09-08 11:49 ` Dan Murphy
2020-09-08 14:58 ` Dan Murphy [this message]
2020-09-08 11:55 ` [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset Dan Murphy
2020-09-08 11:55 ` Dan Murphy
2020-09-08 11:59 ` Peter Ujfalusi
2020-09-08 12:03 ` Peter Ujfalusi
2020-09-08 12:03 ` Peter Ujfalusi
2020-09-09 10:08 ` Camel Guo
2020-09-08 17:20 ` Mark Brown
2020-09-09 10:06 ` Camel Guo
2020-09-09 11:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8160bf81-a72d-2db0-0767-79b0509ff143@ti.com \
--to=dmurphy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=camel.guo@axis.com \
--cc=camelg@axis.com \
--cc=kernel@axis.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®