From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Taniya Das <quic_tdas@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_manafm@quicinc.com
Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add cpu scaling clock node
Date: Mon, 27 Jan 2025 11:54:15 +0100 [thread overview]
Message-ID: <817ae72c-babc-4d87-b935-010b1651d301@oss.qualcomm.com> (raw)
In-Reply-To: <608afa23-ca4e-48dd-b929-4466560a7e61@quicinc.com>
On 20.01.2025 11:57 AM, Taniya Das wrote:
>
>
> On 1/20/2025 4:06 PM, Dmitry Baryshkov wrote:
>> On Mon, 20 Jan 2025 at 12:34, Taniya Das <quic_tdas@quicinc.com> wrote:
>>>
>>>
>>>
>>> On 1/20/2025 2:16 PM, Dmitry Baryshkov wrote:
>>>>>> This doesn't follow the bindings, does it?
>>>>> I will add and re-use the closest target compatible.
>>>>>
>>>>>>> + reg = <0 0x18323000 0 0x1400>,
>>>>>>> + <0 0x18325800 0 0x1400>;
>>>>>>> + reg-names = "freq-domain0", "freq-domain1";
>>>>>>> +
>>>>>>> + clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GPLL0>;
>>>>>>> + clock-names = "xo", "alternate";
>>>>>> Are the DCVSH interrupts?
>>>>>>
>>>>> This target does not have DCVSH interrupts directly connected to the
>>>>> CPUFREQ-HW.
>>>> So, does it require a separate LMH driver, like the one used for sdm845?
>>>
>>> I will check how it is handled on QCS615 as it is closer to SC7180 and I
>>> didn't see any LMH handling there as well.
>>
>> At least sm6150-thermal.dtsi declares two LMH blocks.
>
> QCS615 also has 2 LMH blocks, but the handling of interrupts will be done from the LMH driver, integration with CPUFREQ-HW driver is still under evaluation.
Currently platforms from the 8150 era, using drivers/thermal/qcom/lmh.c
expose the LMH device as an irqchip and pass the per-instance IRQ it
provides to cpufreq, instead of the latter directly consuming a GIC irq
Konrad
prev parent reply other threads:[~2025-01-27 10:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 6:24 [PATCH 0/2] Add support for clock controllers and CPU scaling for QCS615 Taniya Das
2024-11-08 6:24 ` [PATCH 1/2] arm64: dts: qcom: Add clock nodes for multimedia clock Taniya Das
2024-11-08 23:58 ` Dmitry Baryshkov
2025-01-19 10:26 ` Taniya Das
2024-11-08 6:24 ` [PATCH 2/2] arm64: dts: qcom: Add cpu scaling clock node Taniya Das
2024-11-09 0:00 ` Dmitry Baryshkov
2024-12-30 16:42 ` Konrad Dybcio
2025-01-19 10:39 ` Taniya Das
2025-01-19 10:38 ` Taniya Das
2025-01-20 8:46 ` Dmitry Baryshkov
2025-01-20 10:34 ` Taniya Das
2025-01-20 10:36 ` Dmitry Baryshkov
2025-01-20 10:57 ` Taniya Das
2025-01-27 10:54 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=817ae72c-babc-4d87-b935-010b1651d301@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_manafm@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®