From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] clk: qcom: common: Add support for power-domain attachment
Date: Thu, 28 Nov 2024 14:07:00 +0200 [thread overview]
Message-ID: <8189fe4a-b6f5-43a6-9f7f-1abddc366ada@linaro.org> (raw)
In-Reply-To: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-2-836dad33521a@linaro.org>
Hello Bryan.
On 11/27/24 01:44, Bryan O'Donoghue wrote:
> Right now we support one power-domain per clock controller.
> These single power-domains are switched on by the driver platform logic.
>
> However when we have multiple power-domains attached to a clock-controller
> that list of power-domains must be handled outside of driver platform
> logic.
>
> Use devm_pm_domain_attach_list() to automatically hook the list of given
> power-domains in the dtsi for the clock-controller driver.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> drivers/clk/qcom/common.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
Is there any particular reason why my review comment was ignored?
https://lore.kernel.org/all/8a33c0ff-0c6d-4995-b239-023d2a2c2af5@linaro.org/
There is no signs of the change improvement, unfortunately.
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2024-11-28 12:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 23:44 [PATCH v3 0/3] clk: qcom: Add support for multiple power-domains for a clock controller Bryan O'Donoghue
2024-11-26 23:44 ` [PATCH v3 1/3] clk: qcom: gdsc: Capture pm_genpd_add_subdomain result code Bryan O'Donoghue
2024-11-27 3:59 ` Bjorn Andersson
2024-11-26 23:44 ` [PATCH v3 2/3] clk: qcom: common: Add support for power-domain attachment Bryan O'Donoghue
2024-11-28 12:07 ` Vladimir Zapolskiy [this message]
2024-11-28 12:11 ` Bryan O'Donoghue
2024-11-26 23:44 ` [PATCH v3 3/3] driver: clk: qcom: Support attaching subdomain list to multiple parents Bryan O'Donoghue
2024-11-27 4:07 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8189fe4a-b6f5-43a6-9f7f-1abddc366ada@linaro.org \
--to=vladimir.zapolskiy@linaro.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®