[PATCH v2] firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver

[PATCH v2] firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver

[Guillaume La Roque]

With ARCH_K3=y we cannot enable TI_SCI_PROTOCOL=m because
ARCH_K3 selects TI_SCI_PROTOCOL.

Modify the logic to enable TI_SCI_PROTOCOL by default when ARCH_K3=y
allowing us to submit a future patch to remove select on ARCH_K3 without
breaking existing users.

Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
---
Link to comment done on last serie [1] we come back on first version of
series[2] to not use imply but set deps on ARCH_K3 in driver directly.
An other patch will be sent to update Kconfig.platform when this patch
is merged.

[1] https://lore.kernel.org/all/20250123-timodulemailboxsci-v4-1-b1a31b56f162@baylibre.com/
[2] https://lore.kernel.org/all/20221122202245.449198-4-nfrayer@baylibre.com/
---
Changes in v2:
- Update commit message.
- Link to v1: https://lore.kernel.org/r/20250218-ti-firmware-v1-1-7a23aacfb9d3@baylibre.com
---
 drivers/firmware/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 9f35f69e0f9e..109abe063093 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -215,6 +215,7 @@ config SYSFB_SIMPLEFB
 config TI_SCI_PROTOCOL
 	tristate "TI System Control Interface (TISCI) Message Protocol"
 	depends on TI_MESSAGE_MANAGER
+	default ARCH_K3
 	help
 	  TI System Control Interface (TISCI) Message Protocol is used to manage
 	  compute systems such as ARM, DSP etc with the system controller in

---
base-commit: 2408a807bfc3f738850ef5ad5e3fd59d66168996
change-id: 20250218-ti-firmware-1b7c7f485e5a

Best regards,
-- 
Guillaume La Roque <glaroque@baylibre.com>

Re: [PATCH v2] firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver

[Nishanth Menon]

Hi Guillaume La Roque,

On Thu, 20 Feb 2025 14:31:17 +0100, Guillaume La Roque wrote:
> With ARCH_K3=y we cannot enable TI_SCI_PROTOCOL=m because
> ARCH_K3 selects TI_SCI_PROTOCOL.
> 
> Modify the logic to enable TI_SCI_PROTOCOL by default when ARCH_K3=y
> allowing us to submit a future patch to remove select on ARCH_K3 without
> breaking existing users.
> 
> [...]

I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!

[1/1] firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver
      commit: 9a9b7cd77b2427d0722fe52301fa270690928989

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v2] firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver

[Arnd Bergmann]

On Thu, Feb 20, 2025, at 14:31, Guillaume La Roque wrote:
> With ARCH_K3=y we cannot enable TI_SCI_PROTOCOL=m because
> ARCH_K3 selects TI_SCI_PROTOCOL.
>
> Modify the logic to enable TI_SCI_PROTOCOL by default when ARCH_K3=y
> allowing us to submit a future patch to remove select on ARCH_K3 without
> breaking existing users.
>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
> Link to comment done on last serie [1] we come back on first version of
> series[2] to not use imply but set deps on ARCH_K3 in driver directly.
> An other patch will be sent to update Kconfig.platform when this patch
> is merged.

I just merged the patch and hadn't seen the earlier discussion,
just two small notes from me:

- thanks for doing it this way instead of the backwards 'imply'
- there is really no need to split it into two steps, since the
  change to the Kconfig.platforms file logically goes with this
  one and I would merge both through the SoC tree, having it
  as a single patch would make sense.

        Arnd

Re: [PATCH v2] firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver

[Guillaume La Roque]

Le 19/03/2025 à 22:45, Arnd Bergmann a écrit :
> On Thu, Feb 20, 2025, at 14:31, Guillaume La Roque wrote:
>> With ARCH_K3=y we cannot enable TI_SCI_PROTOCOL=m because
>> ARCH_K3 selects TI_SCI_PROTOCOL.
>>
>> Modify the logic to enable TI_SCI_PROTOCOL by default when ARCH_K3=y
>> allowing us to submit a future patch to remove select on ARCH_K3 without
>> breaking existing users.
>>
>> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
>> ---
>> Link to comment done on last serie [1] we come back on first version of
>> series[2] to not use imply but set deps on ARCH_K3 in driver directly.
>> An other patch will be sent to update Kconfig.platform when this patch
>> is merged.
> I just merged the patch and hadn't seen the earlier discussion,
> just two small notes from me:
>
> - thanks for doing it this way instead of the backwards 'imply'
> - there is really no need to split it into two steps, since the
>    change to the Kconfig.platforms file logically goes with this
>    one and I would merge both through the SoC tree, having it
>    as a single patch would make sense.
>
>          Arnd

Hi,

thanks for merged.

i do what we ask me in review in fact or perhaps i misunderstand sorry 
for that.

Guillaume