* [PATCH] afs: fix a compilation issue
@ 2023-01-06 7:59 oushixiong
2023-01-06 13:41 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: oushixiong @ 2023-01-06 7:59 UTC (permalink / raw)
To: David Howells; +Cc: Marc Dionne, linux-afs, linux-kernel, oushixiong, k2ci
fix a compilation issue:
error: no return statement in function returning non-void
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: oushixiong <oushixiong@kylinos.cn>
---
fs/afs/dir.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index b7c1f8c84b38..0522fb61b929 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -49,6 +49,7 @@ static bool afs_dir_dirty_folio(struct address_space *mapping,
struct folio *folio)
{
BUG(); /* This should never happen. */
+ return false;
}
const struct file_operations afs_dir_file_operations = {
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] afs: fix a compilation issue
2023-01-06 7:59 [PATCH] afs: fix a compilation issue oushixiong
@ 2023-01-06 13:41 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2023-01-06 13:41 UTC (permalink / raw)
To: oushixiong; +Cc: dhowells, Marc Dionne, linux-afs, linux-kernel, k2ci
oushixiong <oushixiong@kylinos.cn> wrote:
> BUG(); /* This should never happen. */
> + return false;
This isn't necessary. BUG() should be no-return.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-06 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-06 7:59 [PATCH] afs: fix a compilation issue oushixiong
2023-01-06 13:41 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®