* [PATCH V1] accel/amdxdna: Block running when IOMMU is off
@ 2026-05-20 22:35 Lizhi Hou
2026-05-21 0:57 ` Mario Limonciello
0 siblings, 1 reply; 5+ messages in thread
From: Lizhi Hou @ 2026-05-20 22:35 UTC (permalink / raw)
To: ogabbay, quic_jhugo, dri-devel, mario.limonciello, karol.wachowski
Cc: Lizhi Hou, linux-kernel, max.zhen, sonal.santan
The AIE2 device firmware requires IOMMU on.
Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5319
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
drivers/accel/amdxdna/aie2_pci.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c
index c4d345d4c76b..22f66c7f534d 100644
--- a/drivers/accel/amdxdna/aie2_pci.c
+++ b/drivers/accel/amdxdna/aie2_pci.c
@@ -490,6 +490,11 @@ static int aie2_init(struct amdxdna_dev *xdna)
return -EINVAL;
}
+ if (!xdna->group) {
+ XDNA_ERR(xdna, "Running without IOMMU not supported");
+ return -EINVAL;
+ }
+
ndev = drmm_kzalloc(&xdna->ddev, sizeof(*ndev), GFP_KERNEL);
if (!ndev)
return -ENOMEM;
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH V1] accel/amdxdna: Block running when IOMMU is off
2026-05-20 22:35 [PATCH V1] accel/amdxdna: Block running when IOMMU is off Lizhi Hou
@ 2026-05-21 0:57 ` Mario Limonciello
2026-05-21 3:43 ` Lizhi Hou
0 siblings, 1 reply; 5+ messages in thread
From: Mario Limonciello @ 2026-05-21 0:57 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel, karol.wachowski
Cc: linux-kernel, max.zhen, sonal.santan
On 5/20/26 17:35, Lizhi Hou wrote:
> The AIE2 device firmware requires IOMMU on.
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5319
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
> drivers/accel/amdxdna/aie2_pci.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c
> index c4d345d4c76b..22f66c7f534d 100644
> --- a/drivers/accel/amdxdna/aie2_pci.c
> +++ b/drivers/accel/amdxdna/aie2_pci.c
> @@ -490,6 +490,11 @@ static int aie2_init(struct amdxdna_dev *xdna)
> return -EINVAL;
> }
>
> + if (!xdna->group) {
> + XDNA_ERR(xdna, "Running without IOMMU not supported");
> + return -EINVAL;
> + }
> +
> ndev = drmm_kzalloc(&xdna->ddev, sizeof(*ndev), GFP_KERNEL);
> if (!ndev)
> return -ENOMEM;
I think it would be better to change the return for amdxdna_iommu_init().
This has a check that lets !xdna->group pass; which can be turned into
an error code instead.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH V1] accel/amdxdna: Block running when IOMMU is off
2026-05-21 0:57 ` Mario Limonciello
@ 2026-05-21 3:43 ` Lizhi Hou
2026-05-21 4:32 ` Mario Limonciello
0 siblings, 1 reply; 5+ messages in thread
From: Lizhi Hou @ 2026-05-21 3:43 UTC (permalink / raw)
To: Mario Limonciello, ogabbay, quic_jhugo, dri-devel, karol.wachowski
Cc: linux-kernel, max.zhen, sonal.santan
On 5/20/26 17:57, Mario Limonciello wrote:
>
>
> On 5/20/26 17:35, Lizhi Hou wrote:
>> The AIE2 device firmware requires IOMMU on.
>>
>> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5319
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>> ---
>> drivers/accel/amdxdna/aie2_pci.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_pci.c
>> b/drivers/accel/amdxdna/aie2_pci.c
>> index c4d345d4c76b..22f66c7f534d 100644
>> --- a/drivers/accel/amdxdna/aie2_pci.c
>> +++ b/drivers/accel/amdxdna/aie2_pci.c
>> @@ -490,6 +490,11 @@ static int aie2_init(struct amdxdna_dev *xdna)
>> return -EINVAL;
>> }
>> + if (!xdna->group) {
>> + XDNA_ERR(xdna, "Running without IOMMU not supported");
>> + return -EINVAL;
>> + }
>> +
>> ndev = drmm_kzalloc(&xdna->ddev, sizeof(*ndev), GFP_KERNEL);
>> if (!ndev)
>> return -ENOMEM;
>
> I think it would be better to change the return for amdxdna_iommu_init().
amdxdna_iommu_init() is common code for all kinds of hardware. I would
keep the check only for AIE2 now, which is known to require IOMMU on.
Lizhi
>
> This has a check that lets !xdna->group pass; which can be turned into
> an error code instead.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH V1] accel/amdxdna: Block running when IOMMU is off
2026-05-21 3:43 ` Lizhi Hou
@ 2026-05-21 4:32 ` Mario Limonciello
2026-05-21 17:28 ` Lizhi Hou
0 siblings, 1 reply; 5+ messages in thread
From: Mario Limonciello @ 2026-05-21 4:32 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel, karol.wachowski
Cc: linux-kernel, max.zhen, sonal.santan
On 5/20/26 22:43, Lizhi Hou wrote:
>
> On 5/20/26 17:57, Mario Limonciello wrote:
>>
>>
>> On 5/20/26 17:35, Lizhi Hou wrote:
>>> The AIE2 device firmware requires IOMMU on.
>>>
>>> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5319
>>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>>> ---
>>> drivers/accel/amdxdna/aie2_pci.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/
>>> amdxdna/aie2_pci.c
>>> index c4d345d4c76b..22f66c7f534d 100644
>>> --- a/drivers/accel/amdxdna/aie2_pci.c
>>> +++ b/drivers/accel/amdxdna/aie2_pci.c
>>> @@ -490,6 +490,11 @@ static int aie2_init(struct amdxdna_dev *xdna)
>>> return -EINVAL;
>>> }
>>> + if (!xdna->group) {
>>> + XDNA_ERR(xdna, "Running without IOMMU not supported");
>>> + return -EINVAL;
>>> + }
>>> +
>>> ndev = drmm_kzalloc(&xdna->ddev, sizeof(*ndev), GFP_KERNEL);
>>> if (!ndev)
>>> return -ENOMEM;
>>
>> I think it would be better to change the return for amdxdna_iommu_init().
>
> amdxdna_iommu_init() is common code for all kinds of hardware. I would
> keep the check only for AIE2 now, which is known to require IOMMU on.
Got it. Then this makes sense.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
>
>
> Lizhi
>
>>
>> This has a check that lets !xdna->group pass; which can be turned into
>> an error code instead.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH V1] accel/amdxdna: Block running when IOMMU is off
2026-05-21 4:32 ` Mario Limonciello
@ 2026-05-21 17:28 ` Lizhi Hou
0 siblings, 0 replies; 5+ messages in thread
From: Lizhi Hou @ 2026-05-21 17:28 UTC (permalink / raw)
To: Mario Limonciello, ogabbay, quic_jhugo, dri-devel, karol.wachowski
Cc: linux-kernel, max.zhen, sonal.santan
Applied to drm-misc-fixes
On 5/20/26 21:32, Mario Limonciello wrote:
>
>
> On 5/20/26 22:43, Lizhi Hou wrote:
>>
>> On 5/20/26 17:57, Mario Limonciello wrote:
>>>
>>>
>>> On 5/20/26 17:35, Lizhi Hou wrote:
>>>> The AIE2 device firmware requires IOMMU on.
>>>>
>>>> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5319
>>>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>>>> ---
>>>> drivers/accel/amdxdna/aie2_pci.c | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/
>>>> amdxdna/aie2_pci.c
>>>> index c4d345d4c76b..22f66c7f534d 100644
>>>> --- a/drivers/accel/amdxdna/aie2_pci.c
>>>> +++ b/drivers/accel/amdxdna/aie2_pci.c
>>>> @@ -490,6 +490,11 @@ static int aie2_init(struct amdxdna_dev *xdna)
>>>> return -EINVAL;
>>>> }
>>>> + if (!xdna->group) {
>>>> + XDNA_ERR(xdna, "Running without IOMMU not supported");
>>>> + return -EINVAL;
>>>> + }
>>>> +
>>>> ndev = drmm_kzalloc(&xdna->ddev, sizeof(*ndev), GFP_KERNEL);
>>>> if (!ndev)
>>>> return -ENOMEM;
>>>
>>> I think it would be better to change the return for
>>> amdxdna_iommu_init().
>>
>> amdxdna_iommu_init() is common code for all kinds of hardware. I
>> would keep the check only for AIE2 now, which is known to require
>> IOMMU on.
> Got it. Then this makes sense.
>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
>>
>>
>> Lizhi
>>
>>>
>>> This has a check that lets !xdna->group pass; which can be turned
>>> into an error code instead.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-05-21 17:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-20 22:35 [PATCH V1] accel/amdxdna: Block running when IOMMU is off Lizhi Hou
2026-05-21 0:57 ` Mario Limonciello
2026-05-21 3:43 ` Lizhi Hou
2026-05-21 4:32 ` Mario Limonciello
2026-05-21 17:28 ` Lizhi Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®