mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy@kernel.org>
Cc: Lee Jones <lee@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel_soc_pmic_chtdc_ti: Remove invalid max_register from regmap-config
Date: Sun, 8 Dec 2024 16:00:20 +0100	[thread overview]
Message-ID: <81b7ac42-449b-43be-9bb1-e1c7ba6639f3@redhat.com> (raw)
In-Reply-To: <Z1FiEuqjwpyW4s3Q@smile.fi.intel.com>

Hi Andy,

On 5-Dec-24 9:19 AM, Andy Shevchenko wrote:
> On Wed, Dec 04, 2024 at 10:02:09PM +0100, Hans de Goede wrote:
>> The max_register = 128 setting in the regmap config is not valid.
>>
>> The Intel Dollar Cove TI PMIC has an eeprom unlock register at address 0x88
>> and a number of EEPROM registers at 0xF?. Drop the invalid max_register
>> setting so that these registers can be accessed.
> 
> Wouldn't this break debugfs facility?
> If that is the case, perhaps adding 0xff to it would make more sense?

Ah you are right, I assumed not setting it would just make the regmap
code interpret things as being no maximum. But this does need to be set
for the debugfs regmap dumping to work. I did not realize that.

I'll post a v2 setting it to 0xff instead.

Regards,

Hans



      reply	other threads:[~2024-12-08 15:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04 21:02 Hans de Goede
2024-12-05  8:19 ` Andy Shevchenko
2024-12-08 15:00   ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b7ac42-449b-43be-9bb1-e1c7ba6639f3@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andy@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®