From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Lee Jones <lee@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel_soc_pmic_chtdc_ti: Remove invalid max_register from regmap-config
Date: Thu, 5 Dec 2024 10:19:30 +0200 [thread overview]
Message-ID: <Z1FiEuqjwpyW4s3Q@smile.fi.intel.com> (raw)
In-Reply-To: <20241204210209.136976-1-hdegoede@redhat.com>
On Wed, Dec 04, 2024 at 10:02:09PM +0100, Hans de Goede wrote:
> The max_register = 128 setting in the regmap config is not valid.
>
> The Intel Dollar Cove TI PMIC has an eeprom unlock register at address 0x88
> and a number of EEPROM registers at 0xF?. Drop the invalid max_register
> setting so that these registers can be accessed.
Wouldn't this break debugfs facility?
If that is the case, perhaps adding 0xff to it would make more sense?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-05 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 21:02 Hans de Goede
2024-12-05 8:19 ` Andy Shevchenko [this message]
2024-12-08 15:00 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1FiEuqjwpyW4s3Q@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®