* [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in hp_populate_enumeration_elements_from_package()
@ 2023-07-17 20:53 Christophe JAILLET
2023-07-18 7:55 ` Dan Carpenter
2023-07-25 19:48 ` Lopez, Jorge A (Security)
0 siblings, 2 replies; 5+ messages in thread
From: Christophe JAILLET @ 2023-07-17 20:53 UTC (permalink / raw)
To: Jorge Lopez, Hans de Goede, Mark Gross, Thomas Weißschuh
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, platform-driver-x86
In the loop in the ENUM_POSSIBLE_VALUES case, we allocate some memory that
is never freed.
While at it, add some "str_value = NULL" to avoid some potential double
free.
Fixes: 6b2770bfd6f9 ("platform/x86: hp-bioscfg: enum-attributes")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
/!\ Speculative /!\
This patch is based on analysis of the surrounding code and should be
reviewed with care !
/!\ Speculative /!\
---
drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
index b1b241f0205a..dd173020c747 100644
--- a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
+++ b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
@@ -224,6 +224,7 @@ static int hp_populate_enumeration_elements_from_package(union acpi_object *enum
sizeof(enum_data->common.prerequisites[reqs]));
kfree(str_value);
+ str_value = NULL;
}
break;
@@ -275,6 +276,9 @@ static int hp_populate_enumeration_elements_from_package(union acpi_object *enum
strscpy(enum_data->possible_values[pos_values],
str_value,
sizeof(enum_data->possible_values[pos_values]));
+
+ kfree(str_value);
+ str_value = NULL;
}
break;
default:
@@ -283,6 +287,7 @@ static int hp_populate_enumeration_elements_from_package(union acpi_object *enum
}
kfree(str_value);
+ str_value = NULL;
}
exit_enumeration_package:
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in hp_populate_enumeration_elements_from_package()
2023-07-17 20:53 [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in hp_populate_enumeration_elements_from_package() Christophe JAILLET
@ 2023-07-18 7:55 ` Dan Carpenter
2023-07-18 17:36 ` Christophe JAILLET
2023-07-25 19:48 ` Lopez, Jorge A (Security)
1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2023-07-18 7:55 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Jorge Lopez, Hans de Goede, Mark Gross, Thomas Weißschuh,
linux-kernel, kernel-janitors, platform-driver-x86
On Mon, Jul 17, 2023 at 10:53:37PM +0200, Christophe JAILLET wrote:
> In the loop in the ENUM_POSSIBLE_VALUES case, we allocate some memory that
> is never freed.
>
> While at it, add some "str_value = NULL" to avoid some potential double
> free.
>
> Fixes: 6b2770bfd6f9 ("platform/x86: hp-bioscfg: enum-attributes")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> /!\ Speculative /!\
>
> This patch is based on analysis of the surrounding code and should be
> reviewed with care !
>
> /!\ Speculative /!\
I reported these bugs yesterday. I don't think this is the correct fix.
I thought about making the str_value local to the for loop. That's sort
of like what your patch does. But I wasn't sure that was necessarily
correct either.
This code needs more testing as well. It seems no one has called this
function.
Smatch complained about uninitialized variables as well. I didn't
bother to report that yesterday but I may as well.
regards,
dan carpenter
drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:188 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:191 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:194 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:197 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:200 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:239 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:242 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:245 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:192 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:195 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:198 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:201 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:204 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:238 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:242 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:262 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'value_len'.
drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:198 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:201 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:204 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:207 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:246 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:249 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:252 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:255 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:180 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:183 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:186 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:189 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:192 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:231 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:239 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:279 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:282 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:285 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:288 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:291 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:324 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:327 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:330 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:333 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:362 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in hp_populate_enumeration_elements_from_package()
2023-07-18 7:55 ` Dan Carpenter
@ 2023-07-18 17:36 ` Christophe JAILLET
2023-07-25 20:00 ` Lopez, Jorge A (Security)
0 siblings, 1 reply; 5+ messages in thread
From: Christophe JAILLET @ 2023-07-18 17:36 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jorge Lopez, Hans de Goede, Mark Gross, Thomas Weißschuh,
linux-kernel, kernel-janitors, platform-driver-x86
Le 18/07/2023 à 09:55, Dan Carpenter a écrit :
> On Mon, Jul 17, 2023 at 10:53:37PM +0200, Christophe JAILLET wrote:
>> In the loop in the ENUM_POSSIBLE_VALUES case, we allocate some memory that
>> is never freed.
>>
>> While at it, add some "str_value = NULL" to avoid some potential double
>> free.
>>
>> Fixes: 6b2770bfd6f9 ("platform/x86: hp-bioscfg: enum-attributes")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> /!\ Speculative /!\
>>
>> This patch is based on analysis of the surrounding code and should be
>> reviewed with care !
>>
>> /!\ Speculative /!\
>
> I reported these bugs yesterday.
Ok, seen now...
... but I don't read platform-driver-x86@vger.kernel.org :)
CJ
> I don't think this is the correct fix.
> I thought about making the str_value local to the for loop. That's sort
> of like what your patch does. But I wasn't sure that was necessarily
> correct either.
>
> This code needs more testing as well. It seems no one has called this
> function.
>
> Smatch complained about uninitialized variables as well. I didn't
> bother to report that yesterday but I may as well.
>
> regards,
> dan carpenter
>
> drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:188 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:191 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:194 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:197 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:200 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:239 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:242 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:245 hp_populate_string_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:192 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:195 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:198 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:201 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:204 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:238 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:242 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:262 hp_populate_ordered_list_elements_from_package() error: uninitialized symbol 'value_len'.
> drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:198 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:201 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:204 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:207 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:246 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:249 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:252 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:255 hp_populate_integer_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:180 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:183 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:186 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:189 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:192 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:231 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:239 hp_populate_enumeration_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:279 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:282 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:285 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:288 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:291 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:324 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:327 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:330 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:333 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:362 hp_populate_password_elements_from_package() error: uninitialized symbol 'int_value'.
>
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in hp_populate_enumeration_elements_from_package()
2023-07-18 17:36 ` Christophe JAILLET
@ 2023-07-25 20:00 ` Lopez, Jorge A (Security)
0 siblings, 0 replies; 5+ messages in thread
From: Lopez, Jorge A (Security) @ 2023-07-25 20:00 UTC (permalink / raw)
To: Christophe JAILLET, Dan Carpenter
Cc: Hans de Goede, Mark Gross, Thomas Weißschuh, linux-kernel,
kernel-janitors, platform-driver-x86
Hi Christophe,
I will submit individual patches to address memory leaks and uninitialized variable errors for each source file listed below.
> hp_populate_string_elements_from_package
drivers/platform/x86/hp/hp-bioscfg/string-attributes.c
> hp_populate_ordered_list_elements_from_package()
drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c
> hp_populate_integer_elements_from_package()
drivers/platform/x86/hp/hp-bioscfg/int-attributes.c
> hp_populate_enumeration_elements_from_package()
drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> hp_populate_password_elements_from_package()
drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
Regards,
Jorge Lopez
HP Inc
“Once you stop learning, you start dying”
Albert Einstein
> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Tuesday, July 18, 2023 12:37 PM
> To: Dan Carpenter <dan.carpenter@linaro.org>
> Cc: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>; Hans de Goede
> <hdegoede@redhat.com>; Mark Gross <markgross@kernel.org>; Thomas
> Weißschuh <linux@weissschuh.net>; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org; platform-driver-x86@vger.kernel.org
> Subject: Re: [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in
> hp_populate_enumeration_elements_from_package()
>
> CAUTION: External Email
>
> Le 18/07/2023 à 09:55, Dan Carpenter a écrit :
> > On Mon, Jul 17, 2023 at 10:53:37PM +0200, Christophe JAILLET wrote:
> >> In the loop in the ENUM_POSSIBLE_VALUES case, we allocate some
> memory
> >> that is never freed.
> >>
> >> While at it, add some "str_value = NULL" to avoid some potential
> >> double free.
> >>
> >> Fixes: 6b2770bfd6f9 ("platform/x86: hp-bioscfg: enum-attributes")
> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> >> ---
> >> /!\ Speculative /!\
> >>
> >> This patch is based on analysis of the surrounding code and should be
> >> reviewed with care !
> >>
> >> /!\ Speculative /!\
> >
> > I reported these bugs yesterday.
>
> Ok, seen now...
> ... but I don't read platform-driver-x86@vger.kernel.org :)
>
> CJ
>
> > I don't think this is the correct fix.
> > I thought about making the str_value local to the for loop. That's
> > sort of like what your patch does. But I wasn't sure that was
> > necessarily correct either.
> >
> > This code needs more testing as well. It seems no one has called this
> > function.
> >
> > Smatch complained about uninitialized variables as well. I didn't
> > bother to report that yesterday but I may as well.
> >
> > regards,
> > dan carpenter
> >
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:188
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:191
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:194
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:197
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:200
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:239
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:242
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/string-attributes.c:245
> hp_populate_string_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:192
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:195
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:198
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:201
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:204
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:238
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:242
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c:262
> hp_populate_ordered_list_elements_from_package() error: uninitialized
> symbol 'value_len'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:198
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:201
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:204
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:207
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:246
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:249
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:252
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/int-attributes.c:255
> hp_populate_integer_elements_from_package() error: uninitialized symbol
> 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:180
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:183
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:186
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:189
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:192
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:231
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c:239
> hp_populate_enumeration_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:279
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:282
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:285
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:288
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:291
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:324
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:327
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:330
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:333
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> > drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c:362
> hp_populate_password_elements_from_package() error: uninitialized
> symbol 'int_value'.
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in hp_populate_enumeration_elements_from_package()
2023-07-17 20:53 [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in hp_populate_enumeration_elements_from_package() Christophe JAILLET
2023-07-18 7:55 ` Dan Carpenter
@ 2023-07-25 19:48 ` Lopez, Jorge A (Security)
1 sibling, 0 replies; 5+ messages in thread
From: Lopez, Jorge A (Security) @ 2023-07-25 19:48 UTC (permalink / raw)
To: Christophe JAILLET, Hans de Goede, Mark Gross, Thomas Weißschuh
Cc: linux-kernel, kernel-janitors, platform-driver-x86
Hi Christophe,
I will submit a patch to address memory leaks in hp_populate_enumeration_elements_from_package() reported here and to address some uninitialized variable errors reported in a separate email.
Regards,
Jorge Lopez
HP Inc
"Once you stop learning, you start dying"
Albert Einstein
> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Monday, July 17, 2023 3:54 PM
> To: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>; Hans de Goede
> <hdegoede@redhat.com>; Mark Gross <markgross@kernel.org>; Thomas
> Weißschuh <linux@weissschuh.net>
> Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org;
> Christophe JAILLET <christophe.jaillet@wanadoo.fr>; platform-driver-
> x86@vger.kernel.org
> Subject: [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in
> hp_populate_enumeration_elements_from_package()
>
> CAUTION: External Email
>
> In the loop in the ENUM_POSSIBLE_VALUES case, we allocate some memory
> that is never freed.
>
> While at it, add some "str_value = NULL" to avoid some potential double
> free.
>
> Fixes: 6b2770bfd6f9 ("platform/x86: hp-bioscfg: enum-attributes")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> /!\ Speculative /!\
>
> This patch is based on analysis of the surrounding code and should be
> reviewed with care !
>
> /!\ Speculative /!\
> ---
> drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> index b1b241f0205a..dd173020c747 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> @@ -224,6 +224,7 @@ static int
> hp_populate_enumeration_elements_from_package(union acpi_object
> *enum
> sizeof(enum_data->common.prerequisites[reqs]));
>
> kfree(str_value);
> + str_value = NULL;
> }
> break;
>
> @@ -275,6 +276,9 @@ static int
> hp_populate_enumeration_elements_from_package(union acpi_object
> *enum
> strscpy(enum_data->possible_values[pos_values],
> str_value,
> sizeof(enum_data-
> >possible_values[pos_values]));
> +
> + kfree(str_value);
> + str_value = NULL;
> }
> break;
> default:
> @@ -283,6 +287,7 @@ static int
> hp_populate_enumeration_elements_from_package(union acpi_object
> *enum
> }
>
> kfree(str_value);
> + str_value = NULL;
> }
>
> exit_enumeration_package:
> --
> 2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-25 20:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-17 20:53 [PATCH] platform/x86: hp-bioscfg: Fix some memory leaks in hp_populate_enumeration_elements_from_package() Christophe JAILLET
2023-07-18 7:55 ` Dan Carpenter
2023-07-18 17:36 ` Christophe JAILLET
2023-07-25 20:00 ` Lopez, Jorge A (Security)
2023-07-25 19:48 ` Lopez, Jorge A (Security)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®