Re: [uPATCH] refuse plain ufs mount

[GOTO Masanori <gotom@debian.or.jp>]

At Sun, 25 Jan 2004 01:17:47 +0100 (MET),
Andries.Brouwer@cwi.nl wrote:
> Installed some machine with a reiserfs rootfs.
> The boot messages contain a lot of garbage spouted by Intermezzo
> and ufs_read_super caused by the fact that the kernel tried lots
> of other filesystems before hitting on reiserfs.
> 
> On the one hand this is solved by "rootfstype=reiserfs".
> 
> But on the other hand, the kernel should not complain about the
> guessing it does itself. There is a parameter "silent" for this
> purpose, but in this case I think it cleaner just to remove the
> complaint and tighten the requirement.

I wonder this modification is really ok because user can't find why he
can't mount his ufs if he does not specify ufstype=.  Putting only
one line is not acceptable for you?

Regards,
-- gotom


--- fs/ufs/super.c	2003-10-20 12:50:24.000000000 +0900
+++ fs/ufs/super.c.new	2004-01-27 10:18:22.000000000 +0900
@@ -517,11 +517,8 @@
 		goto failed;
 	}
 	if (!(sbi->s_mount_opt & UFS_MOUNT_UFSTYPE)) {
-		printk("You didn't specify the type of your ufs filesystem\n\n"
-		"mount -t ufs -o ufstype="
-		"sun|sunx86|44bsd|old|hp|nextstep|netxstep-cd|openstep ...\n\n"
-		">>>WARNING<<< Wrong ufstype may corrupt your filesystem, "
-		"default is ufstype=old\n");
+		printk("to mount ufs, specify -o ufstype="
+		"sun|sunx86|44bsd|old(default)|hp|nextstep|netxstep-cd|openstep\n");
 		ufs_set_opt (sbi->s_mount_opt, UFSTYPE_OLD);
 	}