From: Andries.Brouwer@cwi.nl
To: Andries.Brouwer@cwi.nl, torvalds@osdl.org
Cc: akpm@osdl.org, gotom@debian.or.jp, linux-kernel@vger.kernel.org
Subject: Re: [uPATCH] refuse plain ufs mount
Date: Tue, 27 Jan 2004 05:07:50 +0100 (MET) [thread overview]
Message-ID: <UTC200401270407.i0R47oi29367.aeb@smtp.cwi.nl> (raw)
From: Linus Torvalds <torvalds@osdl.org>
> But you see, it wasn't the user at all, and it wasn't a ufs filesystem.
> It is kernel probing that causes error messages. That is unwanted.
> So, your version is wrong.
Yes.
However, I think the _real_ bug is that we have reiserfs near the tail of
filesystems to try.
Can you test that alternate patch instead?
Funny how we alternate - when I choose the pure, theoretical point of view
you prefer practice, when I prefer practice you become pure.
This time you prefer practice: the list of filesystems is full of garbage
and good filesystems should be near the top.
I prefer theory: the kernel should not probe at all, so everybody who
forgets rootfstype= gets what he deserves.
Be that as it may - below a patch as I suppose you had in mind.
I don't like it very much. Ordering constraints in makefiles are bad.
Have not compiled or tested.
You can apply it I suppose, but after doing so my earlier patch is still
meaningful. Maybe you should also apply that (and the Doc update).
Andries
diff -u --recursive --new-file -X /linux/dontdiff a/fs/Makefile b/fs/Makefile
--- a/fs/Makefile 2003-12-18 03:58:57.000000000 +0100
+++ b/fs/Makefile 2004-01-27 04:51:33.000000000 +0100
@@ -48,6 +48,7 @@
obj-$(CONFIG_EXT3_FS) += ext3/ # Before ext2 so root fs can be ext3
obj-$(CONFIG_JBD) += jbd/
obj-$(CONFIG_EXT2_FS) += ext2/
+obj-$(CONFIG_REISERFS_FS) += reiserfs/
obj-$(CONFIG_CRAMFS) += cramfs/
obj-$(CONFIG_RAMFS) += ramfs/
obj-$(CONFIG_HUGETLBFS) += hugetlbfs/
@@ -84,7 +85,6 @@
obj-$(CONFIG_AUTOFS_FS) += autofs/
obj-$(CONFIG_AUTOFS4_FS) += autofs4/
obj-$(CONFIG_ADFS_FS) += adfs/
-obj-$(CONFIG_REISERFS_FS) += reiserfs/
obj-$(CONFIG_UDF_FS) += udf/
obj-$(CONFIG_SUN_OPENPROMFS) += openpromfs/
obj-$(CONFIG_JFS_FS) += jfs/
next reply other threads:[~2004-01-27 4:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-27 4:07 Andries.Brouwer [this message]
2004-01-27 5:04 ` GOTO Masanori
2004-01-27 6:15 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2004-01-28 22:24 Example
2004-01-29 0:13 ` GOTO Masanori
2004-01-27 1:56 Andries.Brouwer
2004-01-27 2:09 ` Linus Torvalds
2004-01-25 0:17 Andries.Brouwer
2004-01-27 1:43 ` GOTO Masanori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200401270407.i0R47oi29367.aeb@smtp.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=gotom@debian.or.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®