From: David Ahern <dsahern@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>, David Ahern <dsa@cumulusnetworks.com>
Cc: acme@kernel.org, mingo@kernel.org, peterz@infradead.org,
namhyung@kernel.org, jolsa@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] perf tool: Move parse_nsec_time to time-utils.c
Date: Mon, 28 Nov 2016 10:31:14 -0700 [thread overview]
Message-ID: <8239a06e-df1e-84cc-ec3c-3fdd22c3fe0a@gmail.com> (raw)
In-Reply-To: <20161128135826.GA1928@krava>
On 11/28/16 6:58 AM, Jiri Olsa wrote:
>> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
>> index 79662d67891e..1d639e38aa82 100644
>> --- a/tools/perf/util/util.h
>> +++ b/tools/perf/util/util.h
>> @@ -179,8 +179,6 @@ static inline void *zalloc(size_t size)
>> #undef tolower
>> #undef toupper
>>
>> -int parse_nsec_time(const char *str, u64 *ptime);
>
> strange, can't see any current user of this function other than in your patch
Added a few years back. I switched my code to it at that point. odd that there are no other users, but it has worked for me since it was added.
>
> could you please also add some automated tests for this function?
Why? It is basically a fancy wrapper around strtoul for sec.usec strings.
next prev parent reply other threads:[~2016-11-28 17:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 21:39 [PATCH 0/6] perf: Add option to specify time window of interest David Ahern
2016-11-25 21:39 ` [PATCH 1/6] perf tool: Add time-based utility functions David Ahern
2016-11-28 13:58 ` Jiri Olsa
2016-11-28 17:35 ` David Ahern
2016-11-28 18:14 ` Jiri Olsa
2016-11-28 18:17 ` David Ahern
2016-11-28 13:58 ` Jiri Olsa
2016-11-28 13:58 ` Jiri Olsa
2016-11-28 17:27 ` David Ahern
2016-11-29 16:02 ` Arnaldo Carvalho de Melo
2016-11-29 16:03 ` David Ahern
2016-11-25 21:39 ` [PATCH 2/6] perf tool: Move parse_nsec_time to time-utils.c David Ahern
2016-11-28 13:58 ` Jiri Olsa
2016-11-28 17:31 ` David Ahern [this message]
2016-11-25 21:39 ` [PATCH 3/6] perf script: Add option to specify time window of interest David Ahern
2016-11-25 21:39 ` [PATCH 4/6] perf sched timehist: " David Ahern
2016-11-25 21:39 ` [PATCH 5/6] perf kmem: " David Ahern
2016-11-25 21:39 ` [PATCH 6/6] perf report: " David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8239a06e-df1e-84cc-ec3c-3fdd22c3fe0a@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@kernel.org \
--cc=dsa@cumulusnetworks.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome