From: David Ahern <dsahern@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>, David Ahern <dsa@cumulusnetworks.com>
Cc: acme@kernel.org, mingo@kernel.org, peterz@infradead.org,
namhyung@kernel.org, jolsa@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] perf tool: Add time-based utility functions
Date: Mon, 28 Nov 2016 10:27:08 -0700 [thread overview]
Message-ID: <99a68c84-ef38-6707-b8d4-16332bda56d4@gmail.com> (raw)
In-Reply-To: <20161128135846.GD1928@krava>
On 11/28/16 6:58 AM, Jiri Olsa wrote:
> On Fri, Nov 25, 2016 at 02:39:54PM -0700, David Ahern wrote:
>
> SNIP
>
>> diff --git a/tools/perf/util/time-utils.h b/tools/perf/util/time-utils.h
>> new file mode 100644
>> index 000000000000..4368a481251d
>> --- /dev/null
>> +++ b/tools/perf/util/time-utils.h
>> @@ -0,0 +1,12 @@
>> +#ifndef _TIME_UTILS_H_
>> +#define _TIME_UTILS_H_
>> +
>> +struct perf_time {
>> + u64 start, end;
>> +};
>
> hum, it's more interval rather than 'time'
> would perf_interval, perf_time_interval suit better?
I'll flip to perf_interval.
ack to the other 2 comments on this patch.
next prev parent reply other threads:[~2016-11-28 17:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 21:39 [PATCH 0/6] perf: Add option to specify time window of interest David Ahern
2016-11-25 21:39 ` [PATCH 1/6] perf tool: Add time-based utility functions David Ahern
2016-11-28 13:58 ` Jiri Olsa
2016-11-28 17:35 ` David Ahern
2016-11-28 18:14 ` Jiri Olsa
2016-11-28 18:17 ` David Ahern
2016-11-28 13:58 ` Jiri Olsa
2016-11-28 13:58 ` Jiri Olsa
2016-11-28 17:27 ` David Ahern [this message]
2016-11-29 16:02 ` Arnaldo Carvalho de Melo
2016-11-29 16:03 ` David Ahern
2016-11-25 21:39 ` [PATCH 2/6] perf tool: Move parse_nsec_time to time-utils.c David Ahern
2016-11-28 13:58 ` Jiri Olsa
2016-11-28 17:31 ` David Ahern
2016-11-25 21:39 ` [PATCH 3/6] perf script: Add option to specify time window of interest David Ahern
2016-11-25 21:39 ` [PATCH 4/6] perf sched timehist: " David Ahern
2016-11-25 21:39 ` [PATCH 5/6] perf kmem: " David Ahern
2016-11-25 21:39 ` [PATCH 6/6] perf report: " David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a68c84-ef38-6707-b8d4-16332bda56d4@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@kernel.org \
--cc=dsa@cumulusnetworks.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®