mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Rob Herring <robh@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	PCI <linux-pci@vger.kernel.org>,
	devicetree@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
Date: Fri, 27 May 2022 18:27:22 +0900	[thread overview]
Message-ID: <82815ff7-08ad-5f31-a249-448f990863e5@socionext.com> (raw)
In-Reply-To: <CAL_JsqJqdLrhjCiQ3a1PZvfnW715HhXNMQZea2H78T4U2BqDzA@mail.gmail.com>

On 2022/05/26 21:46, Rob Herring wrote:
> On Thu, May 26, 2022 at 4:02 AM Kunihiko Hayashi
> <hayashi.kunihiko@socionext.com> wrote:
>>
>> Hi Rob,
>>
>> On 2022/05/26 6:01, Rob Herring wrote:
>>> The Socionext interrupt controller internal to the the PCI block isn't
>>> documented which causes warnings when unevaluatedProperties check is
>>> also fixed. Add the 'interrupt-controller' child node and properties and
>>> fixup the example so that interrupt properties can be parsed.
>>
>> Surely internal interrupt controller isn't described, and should be
>> documented.
>> And the child node name "legacy-interrupt-controller" also should be
>> fixed.
>>
>> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> 
> Thanks.
> 
>>
>> BTW I can't reproduce such warnings with my environment.
>> Can you show the command line to reproduce the warnings?
> 
> "causes warnings when unevaluatedProperties check is also fixed"
> 
> You won't. I have a fix in dtschema pending, but first all the
> warnings that appear need to be fixed.
I understand. I don't care abort the warning on the way to fix.

Thank you,

---
Best Regards
Kunihiko Hayashi

  reply	other threads:[~2022-05-27  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 21:01 Rob Herring
2022-05-26  9:01 ` Kunihiko Hayashi
2022-05-26 12:46   ` Rob Herring
2022-05-27  9:27     ` Kunihiko Hayashi [this message]
2022-05-31 15:19 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82815ff7-08ad-5f31-a249-448f990863e5@socionext.com \
    --to=hayashi.kunihiko@socionext.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®