From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Arnd Bergmann <arnd@kernel.org>, Min Ma <min.ma@amd.com>,
Lizhi Hou <lizhi.hou@amd.com>, Oded Gabbay <ogabbay@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Narendra Gutta <VenkataNarendraKumar.Gutta@amd.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers
Date: Fri, 13 Dec 2024 10:07:00 -0700 [thread overview]
Message-ID: <828570ae-1ff6-4bef-4bb8-51da9237e63e@quicinc.com> (raw)
In-Reply-To: <20241213090259.68492-1-arnd@kernel.org>
On 12/13/2024 2:02 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cause a build
> warning when CONFIG_PM is disabled:
>
> drivers/accel/amdxdna/amdxdna_pci_drv.c:343:12: error: 'amdxdna_pmops_resume' defined but not used [-Werror=unused-function]
> 343 | static int amdxdna_pmops_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/accel/amdxdna/amdxdna_pci_drv.c:328:12: error: 'amdxdna_pmops_suspend' defined but not used [-Werror=unused-function]
> 328 | static int amdxdna_pmops_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Change these to the modern replacements.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks sane to me.
Lizhi, can you verify that this works as expected for you? I'd hate to
accidentally break something.
-Jeff
next prev parent reply other threads:[~2024-12-13 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 9:02 Arnd Bergmann
2024-12-13 9:02 ` [PATCH 2/2] accel/amdxdna: add missing includes Arnd Bergmann
2024-12-13 17:10 ` Jeffrey Hugo
2024-12-13 17:07 ` Jeffrey Hugo [this message]
2024-12-13 17:41 ` [PATCH 1/2] accel/amdxdna: use modern PM helpers Lizhi Hou
2024-12-13 17:49 ` Jeffrey Hugo
2024-12-13 17:57 ` Lizhi Hou
2024-12-13 18:11 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=828570ae-1ff6-4bef-4bb8-51da9237e63e@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=VenkataNarendraKumar.Gutta@amd.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=min.ma@amd.com \
--cc=ogabbay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®