From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Arnd Bergmann <arnd@kernel.org>, Min Ma <min.ma@amd.com>,
Lizhi Hou <lizhi.hou@amd.com>, Oded Gabbay <ogabbay@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, George Yang <George.Yang@amd.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] accel/amdxdna: add missing includes
Date: Fri, 13 Dec 2024 10:10:45 -0700 [thread overview]
Message-ID: <9822274a-26bb-41df-761f-54ad146aa204@quicinc.com> (raw)
In-Reply-To: <20241213090259.68492-2-arnd@kernel.org>
On 12/13/2024 2:02 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This driver fails to build in random configurations:
>
> drivers/accel/amdxdna/amdxdna_mailbox.c:357:8: error: unknown type name 'irqreturn_t'
> 357 | static irqreturn_t mailbox_irq_handler(int irq, void *p)
> | ^~~~~~~~~~~
> drivers/accel/amdxdna/amdxdna_mailbox.c: In function 'mailbox_irq_handler':
> drivers/accel/amdxdna/amdxdna_mailbox.c:367:16: error: 'IRQ_HANDLED' undeclared (first use in this function)
> 367 | return IRQ_HANDLED;
> | ^~~~~~~~~~~
> drivers/accel/amdxdna/amdxdna_mailbox.c:367:16: note: each undeclared identifier is reported only once for each function it appears in
> drivers/accel/amdxdna/amdxdna_mailbox.c: In function 'mailbox_rx_worker':
> drivers/accel/amdxdna/amdxdna_mailbox.c:395:25: error: implicit declaration of function 'disable_irq'; did you mean 'disable_work'? [-Wimplicit-function-declaration]
> 395 | disable_irq(mb_chann->msix_irq);
> | ^~~~~~~~~~~
> drivers/accel/amdxdna/aie2_solver.c: In function 'remove_partition_node':
> drivers/accel/amdxdna/aie2_solver.c:121:9: error: implicit declaration of function 'kfree' [-Wimplicit-function-declaration]
> 121 | kfree(pt_node);
> | ^~~~~
> drivers/accel/amdxdna/aie2_solver.c: In function 'get_free_partition':
> drivers/accel/amdxdna/aie2_solver.c:153:19: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration]
> 153 | pt_node = kzalloc(sizeof(*pt_node), GFP_KERNEL);
>
> Include the headers that have the necessary declarations.
>
> Fixes: c88d3325ae69 ("accel/amdxdna: Add hardware resource solver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> amdxdna: includ linux/interrupt.h
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
The interrupt part of this is now fixed, see "accel/amdxdna: Add include
interrupt.h to amdxdna_mailbox.c".
The slab portion looks sane. I'll trim the patch when applying unless
you'd prefer something else.
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
next prev parent reply other threads:[~2024-12-13 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 9:02 [PATCH 1/2] accel/amdxdna: use modern PM helpers Arnd Bergmann
2024-12-13 9:02 ` [PATCH 2/2] accel/amdxdna: add missing includes Arnd Bergmann
2024-12-13 17:10 ` Jeffrey Hugo [this message]
2024-12-13 17:07 ` [PATCH 1/2] accel/amdxdna: use modern PM helpers Jeffrey Hugo
2024-12-13 17:41 ` Lizhi Hou
2024-12-13 17:49 ` Jeffrey Hugo
2024-12-13 17:57 ` Lizhi Hou
2024-12-13 18:11 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9822274a-26bb-41df-761f-54ad146aa204@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=George.Yang@amd.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=min.ma@amd.com \
--cc=ogabbay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®