mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guopeng Zhang <guopeng.zhang@linux.dev>
To: Ridong Chen <ridong.chen@linux.dev>, Tejun Heo <tj@kernel.org>,
	Waiman Long <longman@redhat.com>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Guopeng Zhang" <zhangguopeng@kylinos.cn>
Subject: Re: [PATCH 1/2] docs: cgroup-v2: Describe boot-isolated CPUs in cpuset.cpus.isolated
Date: Mon, 21 Sep 2026 16:09:38 +0800	[thread overview]
Message-ID: <828b0f0e-b260-4df0-ae90-f89fe8196e48@linux.dev> (raw)
In-Reply-To: <ae7daed1-8fc6-408f-8201-756efc8c5c7d@linux.dev>



在 2026/9/21 12:29, Ridong Chen 写道:
> 
> 
> On 9/18/2026 6:23 PM, Guopeng Zhang wrote:
>> From: Guopeng Zhang <zhangguopeng@kylinos.cn>
>>
>> cpuset.cpus.isolated is documented as empty when no isolated partition
>> exists. This is not true when CPUs are isolated at boot with
>> isolcpus=domain. cpuset_init() adds those CPUs to the isolated mask,
>> and isolcpus=<cpu-list> uses domain isolation by default. They remain
>> listed after a partition using them is released.
>>
>> Document the boot-isolated CPUs as well.
>>
>> Signed-off-by: Guopeng Zhang <zhangguopeng@kylinos.cn>
>> ---
>>   Documentation/admin-guide/cgroup-v2.rst | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
>> index 2ec582985b5b..272e9f2432bd 100644
>> --- a/Documentation/admin-guide/cgroup-v2.rst
>> +++ b/Documentation/admin-guide/cgroup-v2.rst
>> @@ -2625,9 +2625,11 @@ Cpuset Interface Files
>>     cpuset.cpus.isolated
>>       A read-only and root cgroup only multiple values file.
>>   -    This file shows the set of all isolated CPUs used in existing
>> -    isolated partitions. It will be empty if no isolated partition
>> -    is created.
>> +    This file shows CPUs isolated from scheduler domains by
>> +    isolated cpuset partitions or at boot with "isolcpus=domain"
>> +    (including the default "isolcpus=<cpu-list>" form).  CPUs
>> +    isolated at boot remain listed after any partition using them
>> +    is released.
>>       cpuset.cpus.partition
>>       A read-write single value file which exists on non-root
> 
> Could we keep that terminology and avoid repeating "isolated"? Something like:
> 
>       This file shows the set of all isolated CPUs used in existing
>       isolated partitions or isolated at boot time via "isolcpus".
>       The latter remain listed even after any partition using them
>       is released.
> 
> With that:
> 
> Reviewed-by: Ridong Chen <ridong.chen@linux.dev>
> 

Thanks for the suggestion. That reads better.

I'll make one small change and use "the domain flag of isolcpus" here, since isolcpus also supports the nohz and managed_irq flags. I'll update the wording in v2 and add your Reviewed-by.

Thanks,
Guopeng


  reply	other threads:[~2026-09-21  8:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 10:23 [PATCH 0/2] docs: cgroup-v2: Correct cpuset CPU descriptions Guopeng Zhang
2026-09-18 10:23 ` [PATCH 1/2] docs: cgroup-v2: Describe boot-isolated CPUs in cpuset.cpus.isolated Guopeng Zhang
2026-09-21  4:29   ` Ridong Chen
2026-09-21  8:09     ` Guopeng Zhang [this message]
2026-09-18 10:23 ` [PATCH 2/2] docs: cgroup-v2: Describe effective CPUs of partition roots Guopeng Zhang
2026-09-21  6:38   ` Ridong Chen
2026-09-21  8:11     ` Guopeng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=828b0f0e-b260-4df0-ae90-f89fe8196e48@linux.dev \
    --to=guopeng.zhang@linux.dev \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=ridong.chen@linux.dev \
    --cc=skhan@linuxfoundation.org \
    --cc=tj@kernel.org \
    --cc=zhangguopeng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®