From: Vincent Brillault <vincent.brillault@cern.ch>
To: Ivan Delalande <colona@arista.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Kees Cook <keescook@chromium.org>,
Thierry Reding <treding@nvidia.com>,
Geliang Tang <geliangtang@163.com>, Tejun Heo <tj@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: kernel/printk/printk.c: Invalid access when buffer wraps around?
Date: Fri, 5 Aug 2016 07:14:38 +0200 [thread overview]
Message-ID: <82e4f649-0e06-df57-d7ef-3f42bb633644@cern.ch> (raw)
In-Reply-To: <20160801163328.GI26511@ycc.fr>
[-- Attachment #1.1: Type: text/plain, Size: 779 bytes --]
Dear Ivan, all
Sorry for the delay, I currently have limited internet access.
> Thanks for your very detailled write-up but I believe you are mistaken
> on the value of log_first_idx between these two last steps you describe.
After re-reading log_next and log_make_free_space, I believe that you
are right and that I was wrong. Your explanation is crystal-clear and I
now don't understand how I missed this (it's even explained in the
comments...). This means that we might be removing the first element in
the buffer while there was enough space to store it at the end of the
buffer, but I guess this is better than having a bug ;)
I'm sorry for the noise everyone. Thank you for your patience and great
explanation.
Sincerely yours,
Vincent Brillault
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-05 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 9:22 Vincent Brillault
2016-07-31 8:41 ` Sergey Senozhatsky
2016-07-31 13:26 ` Vincent Brillault
2016-08-01 16:33 ` Ivan Delalande
2016-08-05 5:14 ` Vincent Brillault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82e4f649-0e06-df57-d7ef-3f42bb633644@cern.ch \
--to=vincent.brillault@cern.ch \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=colona@arista.com \
--cc=geliangtang@163.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®