mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: Odelu Kukatla <quic_okukatla@quicinc.com>,
	Mike Tipton <quic_mdtipton@quicinc.com>,
	Sibi Sankar <quic_sibis@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5 1/4] dt-bindings: interconnect: Add EPSS L3 compatible for SA8775P
Date: Fri, 22 Nov 2024 12:46:37 +0530	[thread overview]
Message-ID: <82fc7b99-bc3e-4a9b-a472-c1b70671f21a@quicinc.com> (raw)
In-Reply-To: <53876db8-4401-481d-8684-af7e135d481e@kernel.org>



On 11/21/2024 11:20 PM, Krzysztof Kozlowski wrote:
> On 21/11/2024 18:43, Raviteja Laggyshetty wrote:
>>
>>
>> On 11/21/2024 5:23 PM, Krzysztof Kozlowski wrote:
>>> On 21/11/2024 12:30, Raviteja Laggyshetty wrote:
>>>> Add Epoch Subsystem (EPSS) L3 interconnect provider binding on
>>>> SA8775P SoCs.
>>>
>>> This we see from the diff. Explain the hardware, why adding epps-l3-perf.
>>>
>> The EPSS instance in SA8775P uses PERF_STATE register instead of REG_L3_VOTE to scale L3 clocks.Along with SoC specific compatible, add new generic compatible "qcom,epss-l3-perf" for PERF_STATE register based L3 scaling.
> 
> Pasting the same replies as you pasted to others won't solve the
> problem. Solve the problem - fix the commit msg.
> 
>>
>>>>
>>>> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>
>>>> ---
>>>>  .../devicetree/bindings/interconnect/qcom,osm-l3.yaml         | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
>>>> index 21dae0b92819..042ca44c32ec 100644
>>>> --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
>>>> +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
>>>> @@ -34,6 +34,10 @@ properties:
>>>>                - qcom,sm8250-epss-l3
>>>>                - qcom,sm8350-epss-l3
>>>>            - const: qcom,epss-l3
>>>> +      - items:
>>>> +          - enum:
>>>> +              - qcom,sa8775p-epss-l3
>>>> +          - const: qcom,epss-l3-perf
>>>
>>> I don't understand this change in context of driver. These are the same.
>>> Isn't this compatible with sm8250?
>>>
>>
>> The intention for adding "qcom,epss-l3-perf" generic compatible is to use it for the chipsets which use perf state register for l3 scaling.
>> Using generic compatible avoids the need for adding chipset specific compatible in match table.
> 
> 
> Not true, specific compatibles used as fallback do the same and is a
> preferred way.
>

Will make use of sm8250 compatibles for sa8775p in the next patch revision.
 
> 
>> But received comment from konrad to add both SoC-specific and generic compatibles.
> 
> I went through the history and don't see anything like that. Point to
> the specific email please, if you disagree.
> 
https://patchwork.kernel.org/project/linux-pm/patch/20241026123058.28258-2-quic_rlaggysh@quicinc.com/#26104591


>> Dmitry has suggested to update generic comaptibles for sc7280 and sm8250 SoCs, which makes use of perf state registers. 
> 
> OK
> 
>> It will be done as separate patch series.
> 
> No. I expect to see full, correct picture, not half baked patches which
> contradict what is in current code.
> 
>
Ok, I will update the generic compatibles for sm8250, sc7280 SoCs in the 
next patch revision and will include them along with sa8775p dt patch.
 
> Best regards,
> Krzysztof


  reply	other threads:[~2024-11-22  7:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-21 11:30 [PATCH V5 0/4] Add EPSS L3 provider support on SA8775P SoC Raviteja Laggyshetty
2024-11-21 11:30 ` [PATCH V5 1/4] dt-bindings: interconnect: Add EPSS L3 compatible for SA8775P Raviteja Laggyshetty
2024-11-21 11:53   ` Krzysztof Kozlowski
2024-11-21 17:43     ` Raviteja Laggyshetty
2024-11-21 17:50       ` Krzysztof Kozlowski
2024-11-22  7:16         ` Raviteja Laggyshetty [this message]
2024-11-22  7:30           ` Krzysztof Kozlowski
2024-11-21 11:30 ` [PATCH V5 2/4] arm64: dts: qcom: sa8775p: add EPSS l3 interconnect provider Raviteja Laggyshetty
2024-11-21 11:54   ` Krzysztof Kozlowski
2024-11-21 17:49     ` Raviteja Laggyshetty
2024-11-21 17:51       ` Krzysztof Kozlowski
2024-11-21 11:30 ` [PATCH V5 3/4] interconnect: qcom: Add EPSS L3 support on SA8775P Raviteja Laggyshetty
2024-11-21 11:58   ` Krzysztof Kozlowski
2024-11-21 18:03     ` Raviteja Laggyshetty
2024-11-21 22:14       ` Dmitry Baryshkov
2024-11-22  7:18         ` Raviteja Laggyshetty
2024-11-22 12:46       ` Konrad Dybcio
2024-11-21 11:30 ` [PATCH V5 4/4] interconnect: qcom: osm-l3: Add epss compatibles for SA8775P SoC Raviteja Laggyshetty
2024-11-21 11:51   ` Krzysztof Kozlowski
2024-11-22  7:24     ` Raviteja Laggyshetty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82fc7b99-bc3e-4a9b-a472-c1b70671f21a@quicinc.com \
    --to=quic_rlaggysh@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_mdtipton@quicinc.com \
    --cc=quic_okukatla@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®