From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Renjiang Han <quic_renjiang@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v3 2/3] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V4
Date: Wed, 15 Jan 2025 12:02:31 +0000 [thread overview]
Message-ID: <8322416c-5762-4b64-80aa-7ef1b0b0287c@linaro.org> (raw)
In-Reply-To: <20250115-switch_gdsc_mode-v3-2-9a24d2fd724c@quicinc.com>
On 15/01/2025 09:30, Renjiang Han wrote:
> The POWER_CONTROL register addresses are not constant and can vary across
> the variants. Also as per the HW recommendation, the GDSC mode switching
> needs to be controlled from respective GDSC register and this is a uniform
> approach across all the targets. Hence use dev_pm_genpd_set_hwmode() API
> which controls GDSC mode switching using its respective GDSC register.
This paragraph is difficult to read and understand. Try something a bit
more like "Use dev_pm_genpd_set_hwmode() API to control GDSC mode
switching. Do that because of reason x, y z"
"We are making this change because of reason a, b, c"
Basically just try to state the facts as clearly and concisely as possible.
---
bod
next prev parent reply other threads:[~2025-01-15 12:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 9:30 [PATCH v3 0/3] Use APIs in gdsc genpd to switch gdsc mode for venus v4 core Renjiang Han
2025-01-15 9:30 ` [PATCH v3 1/3] clk: qcom: videocc: Use HW_CTRL_TRIGGER flag for video GDSC's Renjiang Han
2025-01-15 9:30 ` [PATCH v3 2/3] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V4 Renjiang Han
2025-01-15 12:02 ` Bryan O'Donoghue [this message]
2025-01-15 20:22 ` Bjorn Andersson
2025-01-15 20:36 ` Bjorn Andersson
2025-01-17 4:19 ` Renjiang Han
2025-01-15 9:30 ` [PATCH v3 3/3] venus: pm_helpers: Remove dead code and simplify power management Renjiang Han
2025-01-15 10:01 ` Dmitry Baryshkov
2025-01-17 4:01 ` Renjiang Han
2025-01-15 9:59 ` [PATCH v3 0/3] Use APIs in gdsc genpd to switch gdsc mode for venus v4 core Dmitry Baryshkov
2025-01-17 4:17 ` Renjiang Han
2025-02-17 10:15 ` Renjiang Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8322416c-5762-4b64-80aa-7ef1b0b0287c@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_renjiang@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=sboyd@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®