From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Can Peng <pengcan@kylinos.cn>, johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] wifi: brcmfmac: remove extra blank lines in msgbuf.c
Date: Wed, 5 Aug 2026 08:01:11 +0200 [thread overview]
Message-ID: <8338ad7e-8707-473c-b677-be3594f7a7f5@broadcom.com> (raw)
In-Reply-To: <20260803080912.553948-1-pengcan@kylinos.cn>
On 03/08/2026 10:09, Can Peng wrote:
> msgbuf.c uses two blank lines in many places, including between
> top-level declarations and functions.
>
> Keep a single blank line instead to match common kernel coding style.
Yeah. It has been like that since this source file was added so maybe
just leave it like it is and forget I ever mentioned it.
Regards,
Arend
> Reviewed-by: johannes@sipsolutions.net
> Reviewed-by: arend.vanspriel@broadcom.com
> Signed-off-by: Can Peng <pengcan@kylinos.cn>
prev parent reply other threads:[~2026-08-05 6:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 8:09 Can Peng
2026-08-05 6:01 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8338ad7e-8707-473c-b677-be3594f7a7f5@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pengcan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®