From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Mark Brown <broonie@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>
Cc: andi.shyti@kernel.org, semen.protsenko@linaro.org,
krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, andre.draszik@linaro.org,
kernel-team@android.com, willmcvicker@google.com,
robh+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] spi: s3c64xx: add support for google,gs101-spi
Date: Tue, 6 Feb 2024 11:19:33 +0000 [thread overview]
Message-ID: <833b96e5-348f-4c5c-b157-c57c9a67e0f2@linaro.org> (raw)
In-Reply-To: <ZcISMLoB2ytoQs/0@finisterre.sirena.org.uk>
On 2/6/24 11:04, Mark Brown wrote:
> On Tue, Feb 06, 2024 at 10:12:30AM +0000, Peter Griffin wrote:
>
>> The patch ordering seems a bit off with this series..I believe it should be
>> 1) dt-bindings patch (docs first)
>> 2) Add the use_32bit_io flag / functionality
>> 3) gs101 support (this patch) that uses the use_32bit_io functionality
>
> That's the ordering the series has? There's a random cleanup patch
> tacked on the front but that really ought to be separate anyway.
I put the include <linux/types.h> patch first because I considered it a
fix (driver is using u32) and because I need types.h in patch 3/4. Fixes
first, then bindings, then driver.
Was I wrong?
next prev parent reply other threads:[~2024-02-06 11:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 8:52 [PATCH 0/4] " Tudor Ambarus
2024-02-06 8:52 ` [PATCH 1/4] spi: s3c64xx: explicitly include <linux/types.h> Tudor Ambarus
2024-02-06 9:56 ` Peter Griffin
2024-02-06 18:02 ` Sam Protsenko
2024-02-07 6:20 ` Tudor Ambarus
2024-02-07 9:58 ` Greg Kroah-Hartman
2024-02-07 10:14 ` Tudor Ambarus
2024-02-07 15:42 ` Sam Protsenko
2024-02-07 16:07 ` Mark Brown
2024-02-06 8:52 ` [PATCH 2/4] spi: dt-bindings: samsung: add google,gs101-spi compatible Tudor Ambarus
2024-02-06 9:57 ` Peter Griffin
2024-02-06 8:52 ` [PATCH 3/4] spi: s3c64xx: add s3c64xx_iowrite{8,16}_32_rep accessors Tudor Ambarus
2024-02-06 18:44 ` Sam Protsenko
2024-02-07 7:04 ` Tudor Ambarus
2024-02-06 8:52 ` [PATCH 4/4] spi: s3c64xx: add support for google,gs101-spi Tudor Ambarus
2024-02-06 10:12 ` Peter Griffin
2024-02-06 11:04 ` Mark Brown
2024-02-06 11:19 ` Tudor Ambarus [this message]
2024-02-06 12:00 ` Peter Griffin
2024-02-06 18:51 ` Sam Protsenko
2024-02-06 18:59 ` [PATCH 0/4] " Sam Protsenko
2024-02-07 7:50 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=833b96e5-348f-4c5c-b157-c57c9a67e0f2@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®