* [PATCH -next] drm/xe: Fix unmet direct dependencies warning
@ 2025-03-22 9:55 Yue Haibing
2025-03-22 12:51 ` Lucas De Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Yue Haibing @ 2025-03-22 9:55 UTC (permalink / raw)
To: lucas.demarchi, thomas.hellstrom, rodrigo.vivi, airlied, simona,
maarten.lankhorst
Cc: intel-xe, dri-devel, linux-kernel, yuehaibing
WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS
Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n]
Selected by [m]:
- DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=m] && DRM_XE [=m] && DRM_XE [=m]=m [=m] && HAS_IOPORT [=y]
FB_IOMEM_HELPERS depends on FB_CORE, Select it before FB_IOMEM_HELPERS.
Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/xe/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index 7d7995196702..fcf324f37d2d 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -53,6 +53,7 @@ config DRM_XE
config DRM_XE_DISPLAY
bool "Enable display support"
depends on DRM_XE && DRM_XE=m && HAS_IOPORT
+ select FB_CORE
select FB_IOMEM_HELPERS
select I2C
select I2C_ALGOBIT
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/xe: Fix unmet direct dependencies warning
2025-03-22 9:55 [PATCH -next] drm/xe: Fix unmet direct dependencies warning Yue Haibing
@ 2025-03-22 12:51 ` Lucas De Marchi
2025-03-23 2:30 ` Yue Haibing
0 siblings, 1 reply; 3+ messages in thread
From: Lucas De Marchi @ 2025-03-22 12:51 UTC (permalink / raw)
To: Yue Haibing
Cc: thomas.hellstrom, rodrigo.vivi, airlied, simona,
maarten.lankhorst, intel-xe, dri-devel, linux-kernel
On Sat, Mar 22, 2025 at 05:55:21PM +0800, Yue Haibing wrote:
>WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS
> Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n]
> Selected by [m]:
> - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=m] && DRM_XE [=m] && DRM_XE [=m]=m [=m] && HAS_IOPORT [=y]
>
>FB_IOMEM_HELPERS depends on FB_CORE, Select it before FB_IOMEM_HELPERS.
>
>Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
>Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>---
> drivers/gpu/drm/xe/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>index 7d7995196702..fcf324f37d2d 100644
>--- a/drivers/gpu/drm/xe/Kconfig
>+++ b/drivers/gpu/drm/xe/Kconfig
>@@ -53,6 +53,7 @@ config DRM_XE
> config DRM_XE_DISPLAY
> bool "Enable display support"
> depends on DRM_XE && DRM_XE=m && HAS_IOPORT
>+ select FB_CORE
other places in drm, including i915 where this is coming from, use:
select FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION
... and don't explicitly select FB_CORE. I think that is sufficient
following the chain of selects which ends up with DRM_CLIENT_LIB
selecting FB_CORE when DRM_FBDEV_EMULATION is set. Does that fixes it
for you?
Lucas De Marchi
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/xe: Fix unmet direct dependencies warning
2025-03-22 12:51 ` Lucas De Marchi
@ 2025-03-23 2:30 ` Yue Haibing
0 siblings, 0 replies; 3+ messages in thread
From: Yue Haibing @ 2025-03-23 2:30 UTC (permalink / raw)
To: Lucas De Marchi
Cc: thomas.hellstrom, rodrigo.vivi, airlied, simona,
maarten.lankhorst, intel-xe, dri-devel, linux-kernel
On 2025/3/22 20:51, Lucas De Marchi wrote:
> On Sat, Mar 22, 2025 at 05:55:21PM +0800, Yue Haibing wrote:
>> WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS
>> Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n]
>> Selected by [m]:
>> - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=m] && DRM_XE [=m] && DRM_XE [=m]=m [=m] && HAS_IOPORT [=y]
>>
>> FB_IOMEM_HELPERS depends on FB_CORE, Select it before FB_IOMEM_HELPERS.
>>
>> Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>> ---
>> drivers/gpu/drm/xe/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>> index 7d7995196702..fcf324f37d2d 100644
>> --- a/drivers/gpu/drm/xe/Kconfig
>> +++ b/drivers/gpu/drm/xe/Kconfig
>> @@ -53,6 +53,7 @@ config DRM_XE
>> config DRM_XE_DISPLAY
>> bool "Enable display support"
>> depends on DRM_XE && DRM_XE=m && HAS_IOPORT
>> + select FB_CORE
>
> other places in drm, including i915 where this is coming from, use:
>
> select FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION
>
> ... and don't explicitly select FB_CORE. I think that is sufficient
> following the chain of selects which ends up with DRM_CLIENT_LIB
> selecting FB_CORE when DRM_FBDEV_EMULATION is set. Does that fixes it
> for you?
Thanks, it works for this, will send v2 soon.
>
> Lucas De Marchi
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-23 2:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-22 9:55 [PATCH -next] drm/xe: Fix unmet direct dependencies warning Yue Haibing
2025-03-22 12:51 ` Lucas De Marchi
2025-03-23 2:30 ` Yue Haibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®