mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Tejun Heo <tj@kernel.org>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
	"Gustavo F. Padovan" <gustavo@padovan.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-bluetooth@vger.kernel.org
Subject: Re: 4.12.0-rc6+: WQ_MEM_RECLAIM hci0:hci_power_off is flushing !WQ_MEM_RECLAIM events:btusb_work
Date: Tue, 27 Jun 2017 19:28:40 +0200	[thread overview]
Message-ID: <83EA7A09-DDFB-4CEB-8F45-52BFDCE3C6DF@holtmann.org> (raw)
In-Reply-To: <20170627152032.GA2289@htj.duckdns.org>

Hi Tejun,

>> On my Dell XPS 13 9343 (x86_64), the following warning was logged right
>> after a resume from suspend-to-mem (not on *every* resume, though, so it
>> might be hard to reproduce). The kernel is v4.12.0-rc6+ as of 94a6df251dd0,
>> and I don't really use bluetooth, though the drivers are loaded:
>> 
>> PM: Finishing wakeup.
>> OOM killer enabled.
>> Restarting tasks ... done.
>> Bluetooth: hci0: read Intel version: 370710018002030d00
>> Bluetooth: hci0: Intel Bluetooth firmware file: intel/ibt-hw-37.7.10-fw-1.80.2.3.d.bseq
>> Bluetooth: hci0: Intel Bluetooth firmware patch completed and activated
>> ... <more, unrelated messages>
>> workqueue: WQ_MEM_RECLAIM hci0:hci_power_off is flushing !WQ_MEM_RECLAIM events:btusb_work
> 
> So, WQ_MEM_RECLAIM has to be transitive; otherwise, it doesn't mean
> anything.  I have a hard time believing that bluetooth actually needs
> WQ_MEM_RECLAIM unless people mount nfs through a bluetooth tethered
> phone.  Would it be possible to remove WQ_MEM_RECLAIM from these
> workqueues?

frankly I do not remember. We used what was recommended to use. I know that the only requirement in one case is that it is a truly single workqueue.

Regards

Marcel

  reply	other threads:[~2017-06-27 17:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-25 18:21 Dominik Brodowski
2017-06-27 15:20 ` Tejun Heo
2017-06-27 17:28   ` Marcel Holtmann [this message]
2017-06-27 17:39     ` Tejun Heo
2017-06-28 10:03       ` Dominik Brodowski
2017-06-28 18:44         ` [PATCH] bluetooth: remove WQ_MEM_RECLAIM from hci workqueues Tejun Heo
2017-06-29 12:37           ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83EA7A09-DDFB-4CEB-8F45-52BFDCE3C6DF@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®