From: Joe Perches <joe@perches.com>
To: Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jolly Shah <jolly.shah@xilinx.com>,
Rajan Vaja <rajan.vaja@xilinx.com>,
Tejas Patel <tejas.patel@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] firmware: xilinx: Properly align function parameter
Date: Tue, 01 Dec 2020 11:42:21 -0800 [thread overview]
Message-ID: <83c7170c7ce6195dc73dcf813965c3e4a99fa4ed.camel@perches.com> (raw)
In-Reply-To: <fb0a22fd12f6a1d69e4e66aafba5b84859d4a60c.1606837822.git.michal.simek@xilinx.com>
On Tue, 2020-12-01 at 16:50 +0100, Michal Simek wrote:
> Fix parameters alignment reported by checkpatch --strict.
Please use a newer checkpatch as the 80 column warning
isn't enforced quite the same way.
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
[]
> @@ -456,7 +456,8 @@ static inline int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type)
> }
>
>
> static inline int zynqmp_pm_reset_assert(const enum zynqmp_pm_reset reset,
> - const enum zynqmp_pm_reset_action assert_flag)
> + const enum zynqmp_pm_reset_action
> + assert_flag)
I think these changes aren't very good as it separates
the type from the variable name.
> @@ -490,9 +491,10 @@ static inline int zynqmp_pm_release_node(const u32 node)
> }
>
>
> static inline int zynqmp_pm_set_requirement(const u32 node,
> - const u32 capabilities,
> - const u32 qos,
> - const enum zynqmp_pm_request_ack ack)
> + const u32 capabilities,
> + const u32 qos,
> + const enum zynqmp_pm_request_ack
> + ack)
next prev parent reply other threads:[~2020-12-01 19:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 15:50 [PATCH 0/3] firmware: xilinx: Clean up series Michal Simek
2020-12-01 15:50 ` [PATCH 1/3] firmware: xilinx: Remove additional newline Michal Simek
2020-12-01 15:50 ` [PATCH 2/3] firmware: xilinx: Add a blank line after function declaration Michal Simek
2020-12-01 15:50 ` [PATCH 3/3] firmware: xilinx: Properly align function parameter Michal Simek
2020-12-01 19:42 ` Joe Perches [this message]
2020-12-02 7:38 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83c7170c7ce6195dc73dcf813965c3e4a99fa4ed.camel@perches.com \
--to=joe@perches.com \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jolly.shah@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=rajan.vaja@xilinx.com \
--cc=tejas.patel@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®