From: YueHaibing <yuehaibing@huawei.com>
To: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] x86: ia32.h: Remove unused code
Date: Fri, 14 Jul 2023 11:16:52 +0800 [thread overview]
Message-ID: <83d2aeb0-9675-10db-f1ca-5ba4ecade4fd@huawei.com> (raw)
In-Reply-To: <20230625125411.25840-1-yuehaibing@huawei.com>
ping...
On 2023/6/25 20:54, YueHaibing wrote:
> Since commit 32974ad4907c ("[IA64] Remove COMPAT_IA32 support")
> IA32_STACK_TOP and ia32_setup_arg_pages() is not used anymore.
> And commit 675a0813609f ("x86: unify mmap_{32|64}.c") left behind
> ia32_pick_mmap_layout() extern declaration.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> arch/x86/include/asm/ia32.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/arch/x86/include/asm/ia32.h b/arch/x86/include/asm/ia32.h
> index fada857f0a1e..68f7eefe63d3 100644
> --- a/arch/x86/include/asm/ia32.h
> +++ b/arch/x86/include/asm/ia32.h
> @@ -57,17 +57,6 @@ struct stat64 {
> unsigned long long st_ino;
> } __attribute__((packed));
>
> -#define IA32_STACK_TOP IA32_PAGE_OFFSET
> -
> -#ifdef __KERNEL__
> -struct linux_binprm;
> -extern int ia32_setup_arg_pages(struct linux_binprm *bprm,
> - unsigned long stack_top, int exec_stack);
> -struct mm_struct;
> -extern void ia32_pick_mmap_layout(struct mm_struct *mm);
> -
> -#endif
> -
> #endif /* CONFIG_IA32_EMULATION */
>
> #endif /* _ASM_X86_IA32_H */
>
next prev parent reply other threads:[~2023-07-14 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 12:54 YueHaibing
2023-06-28 13:16 ` Nikolay Borisov
2023-07-14 3:16 ` YueHaibing [this message]
2024-04-02 13:28 ` [tip: x86/cleanups] x86/32: Remove unused IA32_STACK_TOP and two externs tip-bot2 for YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d2aeb0-9675-10db-f1ca-5ba4ecade4fd@huawei.com \
--to=yuehaibing@huawei.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®