From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Daniel Baluta <daniel.baluta@nxp.com>,
andersson@kernel.org, konradybcio@kernel.org
Cc: robin.clark@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: ubwc: Fix missing include
Date: Mon, 17 Aug 2026 09:59:56 +0200 [thread overview]
Message-ID: <83d95b4e-0dda-4b9b-b3d4-843c0d1f4a21@oss.qualcomm.com> (raw)
In-Reply-To: <20260812132621.679515-1-daniel.baluta@nxp.com>
On 8/12/26 3:26 PM, Daniel Baluta wrote:
> When CONFIG_QCOM_UBWC_CONFIG=n, compiler needs to know the definition
> of ERR_PTR otherwise there will be a compilation error:
>
> In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c:7:
> ./include/linux/soc/qcom/ubwc.h: In function ‘qcom_ubwc_config_get_data’:
> ./include/linux/soc/qcom/ubwc.h:45:16: error: implicit declaration of
> function ‘ERR_PTR’ [-Wimplicit-function-declaration]
>
> Fix this by including <linux/err.h>
>
> Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-08-17 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 13:26 Daniel Baluta
2026-08-12 14:32 ` Dmitry Baryshkov
2026-08-17 7:59 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d95b4e-0dda-4b9b-b3d4-843c0d1f4a21@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.clark@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®