[PATCH] soc: qcom: ubwc: Fix missing include

[PATCH] soc: qcom: ubwc: Fix missing include

[Daniel Baluta]

When CONFIG_QCOM_UBWC_CONFIG=n, compiler needs to know the definition
of ERR_PTR otherwise there will be a compilation error:

In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c:7:
./include/linux/soc/qcom/ubwc.h: In function ‘qcom_ubwc_config_get_data’:
./include/linux/soc/qcom/ubwc.h:45:16: error: implicit declaration of
function ‘ERR_PTR’ [-Wimplicit-function-declaration]

Fix this by including <linux/err.h>

Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
 include/linux/soc/qcom/ubwc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h
index a7372d9c25fbc..f3a70360b177b 100644
--- a/include/linux/soc/qcom/ubwc.h
+++ b/include/linux/soc/qcom/ubwc.h
@@ -8,6 +8,7 @@
 #define __QCOM_UBWC_H__
 
 #include <linux/bits.h>
+#include <linux/err.h>
 #include <linux/printk.h>
 #include <linux/types.h>
 
-- 
2.45.2

Re: [PATCH] soc: qcom: ubwc: Fix missing include

[Dmitry Baryshkov]

On Wed, Aug 12, 2026 at 04:26:21PM +0300, Daniel Baluta wrote:
> When CONFIG_QCOM_UBWC_CONFIG=n, compiler needs to know the definition
> of ERR_PTR otherwise there will be a compilation error:
> 
> In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c:7:
> ./include/linux/soc/qcom/ubwc.h: In function ‘qcom_ubwc_config_get_data’:
> ./include/linux/soc/qcom/ubwc.h:45:16: error: implicit declaration of
> function ‘ERR_PTR’ [-Wimplicit-function-declaration]
> 
> Fix this by including <linux/err.h>
> 
> Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
>  include/linux/soc/qcom/ubwc.h | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH] soc: qcom: ubwc: Fix missing include

[Konrad Dybcio]

On 8/12/26 3:26 PM, Daniel Baluta wrote:
> When CONFIG_QCOM_UBWC_CONFIG=n, compiler needs to know the definition
> of ERR_PTR otherwise there will be a compilation error:
> 
> In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c:7:
> ./include/linux/soc/qcom/ubwc.h: In function ‘qcom_ubwc_config_get_data’:
> ./include/linux/soc/qcom/ubwc.h:45:16: error: implicit declaration of
> function ‘ERR_PTR’ [-Wimplicit-function-declaration]
> 
> Fix this by including <linux/err.h>
> 
> Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad