mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Christoph Lameter" <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	jsipek@fsl.cs.sunysb.edu, unionfs@filesystems.org,
	bunk@stusta.de, hooanon05@yahoo.co.jp
Subject: Re: [PATCH 1/3] slab: introduce krealloc
Date: Wed, 21 Feb 2007 21:19:33 +0200	[thread overview]
Message-ID: <84144f020702211119ub028ccahee15629f02491840@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0702211041061.24941@schroedinger.engr.sgi.com>

On 2/21/07, Christoph Lameter <clameter@sgi.com> wrote:
> Why not? Its a realloc call and these are the classic semantics of
> realloc. Otherwise realloc will always move the memory.

Well, as a reference, the user-space equivalent is defined in SUSv3 as:

"The realloc() function shall change the size of the memory object
pointed to by ptr to the size specified by size."

I think it is reasonable to expect krealloc() to not waste too much
space if I, say, reallocate a 128 byte buffer to 32 bytes.

On 2/21/07, Christoph Lameter <clameter@sgi.com> wrote:
> Check that both sizes fall into the same general cache. Do the following
> at the beginning of the function

Not available in the slob allocator AFAIK but yeah, I'll add this
optimization to the slab version. Thanks Christoph.

                             Pekka

  reply	other threads:[~2007-02-21 19:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-21  8:06 Pekka J Enberg
2007-02-21  9:24 ` Arjan van de Ven
2007-02-21  9:33   ` Pekka Enberg
2007-02-21  9:36     ` Arjan van de Ven
2007-02-21 17:51     ` Christoph Lameter
2007-02-21 17:53 ` Christoph Lameter
2007-02-21 18:21   ` Pekka Enberg
2007-02-21 18:27     ` Christoph Lameter
2007-02-21 18:37       ` Pekka Enberg
2007-02-21 18:48         ` Christoph Lameter
2007-02-21 19:19           ` Pekka Enberg [this message]
2007-02-21 19:22             ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020702211119ub028ccahee15629f02491840@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@stusta.de \
    --cc=clameter@sgi.com \
    --cc=hooanon05@yahoo.co.jp \
    --cc=jsipek@fsl.cs.sunysb.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=unionfs@filesystems.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®