From: Christoph Lameter <clameter@sgi.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
jsipek@fsl.cs.sunysb.edu, unionfs@filesystems.org,
bunk@stusta.de, hooanon05@yahoo.co.jp
Subject: Re: [PATCH 1/3] slab: introduce krealloc
Date: Wed, 21 Feb 2007 10:27:06 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702211023300.24719@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <45DC8DA1.6030100@cs.helsinki.fi>
On Wed, 21 Feb 2007, Pekka Enberg wrote:
> Christoph Lameter wrote:
> > Well could you check ksize for the old object first and if ksize <= new size
> > then just skip the copy? I think this may allow you to get rid of the ksize
> > callers.
>
> And not reallocate at all, right? I thought about that but then you wouldn't
> be able to use realloc() to make the buffer smaller.
I think there are two ways to address that:
1. Just do not allow shrinking via realloc. Probably no big loss and best
performance.
2. Check if the size specified is larger than the next smallest general
cache and only copy if we would really would allocate from a different
cache.
next prev parent reply other threads:[~2007-02-21 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 8:06 Pekka J Enberg
2007-02-21 9:24 ` Arjan van de Ven
2007-02-21 9:33 ` Pekka Enberg
2007-02-21 9:36 ` Arjan van de Ven
2007-02-21 17:51 ` Christoph Lameter
2007-02-21 17:53 ` Christoph Lameter
2007-02-21 18:21 ` Pekka Enberg
2007-02-21 18:27 ` Christoph Lameter [this message]
2007-02-21 18:37 ` Pekka Enberg
2007-02-21 18:48 ` Christoph Lameter
2007-02-21 19:19 ` Pekka Enberg
2007-02-21 19:22 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702211023300.24719@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=hooanon05@yahoo.co.jp \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=unionfs@filesystems.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®