From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 2/5] revoke: core code
Date: Fri, 16 Mar 2007 16:30:04 +0200 [thread overview]
Message-ID: <84144f020703160730y7cd692efx264635fe4683398b@mail.gmail.com> (raw)
In-Reply-To: <20070316145855.5604d7d8@lxorguk.ukuu.org.uk>
On 3/16/07, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > I'm not sure that running do_fsync() will guarantee that all sys_write()
> > callers will have finished their syscall. Probably they will have, in
> > practice. But there is logic in the sync paths to deliberately bale out
> > if we're competing with ongoing dirtyings, to avoid livelocking.
>
> For device files you really need to call into the device driver for this
> (->flush etc).
Sure but the do_fsync() bits are part of generic_file_revoke() which
is not meant for device files at all.
next prev parent reply other threads:[~2007-03-16 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-11 11:30 Pekka J Enberg
2007-03-16 1:34 ` Andrew Morton
2007-03-16 6:44 ` Pekka Enberg
2007-03-16 11:26 ` Andrew Morton
2007-03-16 11:44 ` Pekka J Enberg
2007-03-16 12:26 ` Andrew Morton
2007-03-16 14:45 ` Pekka J Enberg
2007-03-16 14:58 ` Alan Cox
2007-03-16 14:27 ` Pekka Enberg
2007-03-16 14:46 ` Pekka Enberg
2007-03-16 14:30 ` Pekka Enberg [this message]
2007-03-16 20:37 ` Pekka Enberg
2007-03-16 20:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020703160730y7cd692efx264635fe4683398b@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®